mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
Closes https://github.com/elastic/kibana/issues/165974
The root cause of the problem is calling `basePath.prepend` on a path
without a leading `/`. Maps is not consistent with path constants. Some
have leading `/` while others do not. To resolve the issue, this PR
updates all path constants to consistently have leading `/`.
PR adds functional test runner with `map.includeElasticMapsService:
false` to ensure maps is tested without EMS enabled to catch future
regressions.
### Test instructions
* set *map.includeElasticMapsService: false* in kibana.dev.yml
* install sample data set
* create new map with documents layer
* Configure label styling
* Verify layer is displayed with labels
<img width="500" alt="Screen Shot 2023-09-13 at 6 26 23 AM"
src="44d12e87
-9b80-424c-9bc9-126b373bdf18">
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
32 lines
1,018 B
TypeScript
32 lines
1,018 B
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License
|
|
* 2.0; you may not use this file except in compliance with the Elastic License
|
|
* 2.0.
|
|
*/
|
|
|
|
import { FtrConfigProviderContext } from '@kbn/test';
|
|
import { services, pageObjects } from './ftr_provider_context';
|
|
|
|
export default async function ({ readConfigFile }: FtrConfigProviderContext) {
|
|
const kibanaFunctionalConfig = await readConfigFile(
|
|
require.resolve('../functional/config.base.js')
|
|
);
|
|
|
|
return {
|
|
...kibanaFunctionalConfig.getAll(),
|
|
testFiles: [require.resolve('./tests')],
|
|
services,
|
|
pageObjects,
|
|
junit: {
|
|
reportName: `Kibana Maps without access to Elastic Maps Service`,
|
|
},
|
|
kbnTestServer: {
|
|
...kibanaFunctionalConfig.get('kbnTestServer'),
|
|
serverArgs: [
|
|
...kibanaFunctionalConfig.get('kbnTestServer.serverArgs'),
|
|
`--map.includeElasticMapsService=false`,
|
|
],
|
|
},
|
|
};
|
|
}
|