kibana

mirror of https://github.com/elastic/kibana.git synced 2025-04-23 01:13:23 -04:00

History

Drew Tate f136782fd4 [Dashboard] Keep managed panels out of unmanaged dashboards (#176006 ) ## Summary Close https://github.com/elastic/kibana/issues/172383 Close https://github.com/elastic/kibana/issues/172384 This PR introduces a [new embeddable-related registry](https://github.com/elastic/kibana/pull/176006/files#diff-1401b355377c76ab6458756aa0e3177beef5ec56796c58b7a52b5e003f85b5cf) which clients can use to define a custom transformation from saved object to embeddable input during the add-panel-from-library sequence. Then, each content type uses this to communicate whether a particular object should be added by-ref or by-val based on the presence of `managed: true` on the saved object ([example](https://github.com/elastic/kibana/pull/176006/files#diff-3baaeaeef5893a5a4db6379a1ed888406a8584cb9d0c7440f273040e4aa28166R157-R167)). ### Managed panels are added by-value to dashboards <img width="400" alt="Screenshot 2024-02-01 at 12 24 06 PM" src="`42a695d4`-fccf-45bf-bd6a-8d8fc606d04e"> ### Cloning a managed dashboard inlines all by-ref panels `ca6e763c`-cc02-46cb-9164-abd91deca081 ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — will happen in https://github.com/elastic/kibana/issues/175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5031 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>	2024-02-07 07:46:41 -06:00
..
es_archiver	Fix broken tests as a result of tsid hashing (#176120 )	2024-02-02 16:24:41 -04:00
kbn_archiver	[Dashboard] Keep managed panels out of unmanaged dashboards (#176006 )	2024-02-07 07:46:41 -06:00

[Dashboard] Keep managed panels out of unmanaged dashboards (#176006 )

## Summary

Close https://github.com/elastic/kibana/issues/172383
Close https://github.com/elastic/kibana/issues/172384

This PR introduces a [new embeddable-related
registry](https://github.com/elastic/kibana/pull/176006/files#diff-1401b355377c76ab6458756aa0e3177beef5ec56796c58b7a52b5e003f85b5cf)
which clients can use to define a custom transformation from saved
object to embeddable input during the add-panel-from-library sequence.

Then, each content type uses this to communicate whether a particular
object should be added by-ref or by-val based on the presence of
`managed: true` on the saved object
([example](https://github.com/elastic/kibana/pull/176006/files#diff-3baaeaeef5893a5a4db6379a1ed888406a8584cb9d0c7440f273040e4aa28166R157-R167)).



### Managed panels are added by-value to dashboards

<img width="400" alt="Screenshot 2024-02-01 at 12 24 06 PM"
src="42a695d4-fccf-45bf-bd6a-8d8fc606d04e">

### Cloning a managed dashboard inlines all by-ref panels


ca6e763c-cc02-46cb-9164-abd91deca081

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will
happen in https://github.com/elastic/kibana/issues/175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed —
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5031
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

2024-02-07 07:46:41 -06:00

es_archiver Fix broken tests as a result of tsid hashing (#176120 ) 2024-02-02 16:24:41 -04:00

kbn_archiver [Dashboard] Keep managed panels out of unmanaged dashboards (#176006 ) 2024-02-07 07:46:41 -06:00