mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
f4a0b8c986
# Backport This will backport the following commits from `main` to `8.x`: - [[Embeddable Rebuild] [Controls] Remove non-React controls from `controls` plugin (#192017)](https://github.com/elastic/kibana/pull/192017) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-17T14:12:54Z","message":"[Embeddable Rebuild] [Controls] Remove non-React controls from `controls` plugin (#192017)\n\nPart of https://github.com/elastic/kibana/issues/192005\r\nCloses https://github.com/elastic/kibana/issues/176533\r\n\r\n## Summary\r\n\r\nThis PR represents the first major cleanup task for the control group\r\nembeddable refactor. The tasks included in this PR can be loosely\r\nsummarized as follows:\r\n1. This PR removes the old, non-React version of controls \r\n- Note that the new controls are still included under the\r\n`react_controls` folder - I will address this in a follow up PR.\r\n2. This PR removes **all** types associated with the old embeddable\r\nsystem; i.e. any `*input*` or `*output*` types.\r\n- As part of cleaning up these types, some of the types included in the\r\n`public/react_controls` folder had to be moved to `common` to make them\r\navailable to server-side code.\r\n- This resulted in an... unfortunate number of import changes 🫠 Hence\r\nthe rather large file change count. I took this opportunity to organize\r\nthe imports, too - so a significant chunk of these files are simply\r\nimport changes.\r\n3. This PR removes the controls Storybook and all related mocks\r\n- Since the controls storybooks have been broken for awhile, and since\r\nwe had plans to remove them but never got around to it, I just decided\r\nto delete them as part of this PR and close\r\nhttps://github.com/elastic/kibana/issues/176533 rather than spending\r\ntime to fix the types for non-operational stories\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5082eef2f1df8b6d7e9bb15d2221b9f4c67b00bf","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","impact:critical","v9.0.0","backport:prev-minor","project:embeddableRebuild"],"title":"[Embeddable Rebuild] [Controls] Remove non-React controls from `controls` plugin","number":192017,"url":"https://github.com/elastic/kibana/pull/192017","mergeCommit":{"message":"[Embeddable Rebuild] [Controls] Remove non-React controls from `controls` plugin (#192017)\n\nPart of https://github.com/elastic/kibana/issues/192005\r\nCloses https://github.com/elastic/kibana/issues/176533\r\n\r\n## Summary\r\n\r\nThis PR represents the first major cleanup task for the control group\r\nembeddable refactor. The tasks included in this PR can be loosely\r\nsummarized as follows:\r\n1. This PR removes the old, non-React version of controls \r\n- Note that the new controls are still included under the\r\n`react_controls` folder - I will address this in a follow up PR.\r\n2. This PR removes **all** types associated with the old embeddable\r\nsystem; i.e. any `*input*` or `*output*` types.\r\n- As part of cleaning up these types, some of the types included in the\r\n`public/react_controls` folder had to be moved to `common` to make them\r\navailable to server-side code.\r\n- This resulted in an... unfortunate number of import changes 🫠 Hence\r\nthe rather large file change count. I took this opportunity to organize\r\nthe imports, too - so a significant chunk of these files are simply\r\nimport changes.\r\n3. This PR removes the controls Storybook and all related mocks\r\n- Since the controls storybooks have been broken for awhile, and since\r\nwe had plans to remove them but never got around to it, I just decided\r\nto delete them as part of this PR and close\r\nhttps://github.com/elastic/kibana/issues/176533 rather than spending\r\ntime to fix the types for non-operational stories\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5082eef2f1df8b6d7e9bb15d2221b9f4c67b00bf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192017","number":192017,"mergeCommit":{"message":"[Embeddable Rebuild] [Controls] Remove non-React controls from `controls` plugin (#192017)\n\nPart of https://github.com/elastic/kibana/issues/192005\r\nCloses https://github.com/elastic/kibana/issues/176533\r\n\r\n## Summary\r\n\r\nThis PR represents the first major cleanup task for the control group\r\nembeddable refactor. The tasks included in this PR can be loosely\r\nsummarized as follows:\r\n1. This PR removes the old, non-React version of controls \r\n- Note that the new controls are still included under the\r\n`react_controls` folder - I will address this in a follow up PR.\r\n2. This PR removes **all** types associated with the old embeddable\r\nsystem; i.e. any `*input*` or `*output*` types.\r\n- As part of cleaning up these types, some of the types included in the\r\n`public/react_controls` folder had to be moved to `common` to make them\r\navailable to server-side code.\r\n- This resulted in an... unfortunate number of import changes 🫠 Hence\r\nthe rather large file change count. I took this opportunity to organize\r\nthe imports, too - so a significant chunk of these files are simply\r\nimport changes.\r\n3. This PR removes the controls Storybook and all related mocks\r\n- Since the controls storybooks have been broken for awhile, and since\r\nwe had plans to remove them but never got around to it, I just decided\r\nto delete them as part of this PR and close\r\nhttps://github.com/elastic/kibana/issues/176533 rather than spending\r\ntime to fix the types for non-operational stories\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5082eef2f1df8b6d7e9bb15d2221b9f4c67b00bf"}}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| app | ||
| constants.ts | ||
| control_group_image.png | ||
| index.ts | ||
| plugin.tsx | ||
