mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
43fde917fb
# Backport This will backport the following commits from `main` to `8.18`: - [[Discover] Fix CSV for ES|QL embeddable (#216325)](https://github.com/elastic/kibana/pull/216325) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-02T13:14:55Z","message":"[Discover] Fix CSV for ES|QL embeddable (#216325)\n\n- Closes https://github.com/elastic/kibana/issues/215893\n\n## Summary\n\nThis PR extract the logic from Share > Export > Generate CSV into new\nutils and uses it to fix CSV export for Dashboard panels.\n\n<img width=\"903\" alt=\"Screenshot 2025-04-01 at 12 05 58\"\nsrc=\"https://github.com/user-attachments/assets/20e611d7-b1da-4b50-a8fc-e18ac3db3a55\"\n/>\n\n\n## Testing\n\nPlease test for both data view mode and ES|QL mode. The steps are the\nfollowing:\n1. Save a discover session\n2. Add it to a new dashboard\n3. Save the Dashboard and switch to View mode\n4. Via panel actions, press \"Generate CSV report\"\n5. Compare the CSV results with what is shown in the grid\n6. Add a custom time range to the panel via panel actions \"Settings\"\n7. Generate a CSV report and compare results again\n\nAlso check that reporting still works when generated from Discover page.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"dc78614d29da8f64f77840d3fc02846fcacfe2e5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","v9.0.0","Team:DataDiscovery","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Discover] Fix CSV for ES|QL embeddable","number":216325,"url":"https://github.com/elastic/kibana/pull/216325","mergeCommit":{"message":"[Discover] Fix CSV for ES|QL embeddable (#216325)\n\n- Closes https://github.com/elastic/kibana/issues/215893\n\n## Summary\n\nThis PR extract the logic from Share > Export > Generate CSV into new\nutils and uses it to fix CSV export for Dashboard panels.\n\n<img width=\"903\" alt=\"Screenshot 2025-04-01 at 12 05 58\"\nsrc=\"https://github.com/user-attachments/assets/20e611d7-b1da-4b50-a8fc-e18ac3db3a55\"\n/>\n\n\n## Testing\n\nPlease test for both data view mode and ES|QL mode. The steps are the\nfollowing:\n1. Save a discover session\n2. Add it to a new dashboard\n3. Save the Dashboard and switch to View mode\n4. Via panel actions, press \"Generate CSV report\"\n5. Compare the CSV results with what is shown in the grid\n6. Add a custom time range to the panel via panel actions \"Settings\"\n7. Generate a CSV report and compare results again\n\nAlso check that reporting still works when generated from Discover page.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"dc78614d29da8f64f77840d3fc02846fcacfe2e5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216325","number":216325,"mergeCommit":{"message":"[Discover] Fix CSV for ES|QL embeddable (#216325)\n\n- Closes https://github.com/elastic/kibana/issues/215893\n\n## Summary\n\nThis PR extract the logic from Share > Export > Generate CSV into new\nutils and uses it to fix CSV export for Dashboard panels.\n\n<img width=\"903\" alt=\"Screenshot 2025-04-01 at 12 05 58\"\nsrc=\"https://github.com/user-attachments/assets/20e611d7-b1da-4b50-a8fc-e18ac3db3a55\"\n/>\n\n\n## Testing\n\nPlease test for both data view mode and ES|QL mode. The steps are the\nfollowing:\n1. Save a discover session\n2. Add it to a new dashboard\n3. Save the Dashboard and switch to View mode\n4. Via panel actions, press \"Generate CSV report\"\n5. Compare the CSV results with what is shown in the grid\n6. Add a custom time range to the panel via panel actions \"Settings\"\n7. Generate a CSV report and compare results again\n\nAlso check that reporting still works when generated from Discover page.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"dc78614d29da8f64f77840d3fc02846fcacfe2e5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216851","number":216851,"state":"OPEN"}]}] BACKPORT--> |
||
|---|---|---|
| .. | ||
| apps | ||
| es_archives | ||
| fixtures | ||
| page_objects | ||
| screenshots/baseline | ||
| services | ||
| config.base.js | ||
| config.ccs.ts | ||
| config.edge.js | ||
| config.firefox.js | ||
| config.upgrade_assistant.ts | ||
| config_security_basic.ts | ||
| ftr_provider_context.ts | ||
| README.md | ||
Kibana Functional Testing
See our Functional Testing Guide