kibana/test
Catherine Liu 229b3e8a5a
[Dashboard] Check suggested dashboard title for duplicates on save as (#184777)
## Summary

Follow up to #180938.

On `Save as`, the suggested title should always be a unique title. I've
added a check for duplicate titles when generating a suggested new
dashboard title. If the dashboards `Dashboard A`, `Dashboard A (1)`, and
`Dashboard A (2)` already exist, the next suggested dashboard title will
be `Dashboard A (3)`. This way the user doesn't end up hitting the
duplicate title warning if they want to quickly clone a dashboard
without updating the title.

![Jun-04-2024
12-27-59](b1f1ae1a-87d3-4dcd-80cd-395bd6ee9800)

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Eyo Okon Eyo <eyo.eyo@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2024-06-08 02:54:56 +02:00
..
accessibility Simplify workflow for dashboard copy creation in both view and edit interaction modes (#180938) 2024-05-29 11:46:23 +02:00
analytics [Obs AI Assistant] Add tests for if chat telemetry is sent and correctly shaped (#181086) 2024-05-02 12:00:56 +02:00
api_integration Add http2 support for Kibana server (#183465) 2024-06-03 09:34:13 +02:00
common Add http2 support for Kibana server (#183465) 2024-06-03 09:34:13 +02:00
examples [ML] Adds redux toolkit example for response_stream to developer examples. (#182690) 2024-05-22 16:51:36 +02:00
functional [Dashboard] Check suggested dashboard title for duplicates on save as (#184777) 2024-06-08 02:54:56 +02:00
harden Add test to ensure security related eslint rules are applied (#151434) 2023-02-24 16:48:11 +01:00
health_gateway async-import plugins in the server side (#170856) 2023-11-15 00:55:56 -07:00
interactive_setup_api_integration async-import plugins in the server side (#170856) 2023-11-15 00:55:56 -07:00
interactive_setup_functional Unskip interactive setup functional tests (#157863) 2023-05-16 09:20:00 -04:00
interpreter_functional Use rxjs instead of rxjs/operators (#179553) 2024-04-02 11:41:33 -07:00
node_roles_functional async-import plugins in the server side (#170856) 2023-11-15 00:55:56 -07:00
package [FIPS / CI] Fix ES ML startup issues, UUID permissions, FTR tests status, OpenSSL target. Switch to Ubuntu (#182295) 2024-05-16 08:13:57 -07:00
plugin_functional [Stateful sidenav] Add cloud yml setting for onboarding default solution (#184808) 2024-06-06 10:06:21 -07:00
scripts [ci] Remove jenkins config (#173745) 2023-12-21 12:09:43 -06:00
server_integration Use permanent cache for translation files on production (#181377) 2024-04-24 13:31:06 +02:00
ui_capabilities/newsfeed_err [ftr] automatically determine config run order (#130983) 2022-05-04 17:05:58 -05:00
tsconfig.json [ES|QL] Remove version from _query requests (#184289) 2024-05-29 10:48:31 +02:00