mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
0ec6573aa8
# Backport This will backport the following commits from `main` to `8.17`: - [[Data View Field] Fix popularity score bugs (#211201)](https://github.com/elastic/kibana/pull/211201) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-02-27T10:34:22Z","message":"[Data View Field] Fix popularity score bugs (#211201)\n\n- Fixes https://github.com/elastic/kibana/issues/211109\n\n## Summary\n\nThis PR fixes a number of bugs in fields popularity logic:\n- [x] If field popularity was customized via UI form, the value will be\nsaved now as a number instead of a string\n- [x] Same for runtime fields in another part of the code\n- [x] Since the data was polluted with string values, this PR makes sure\nthat the incrementing would still work and the result would be converted\nto number.\n- [x] If user opened the field flyout, when selected/deselected fields\nas columns in the table, then opened the field flyout again, the data\nshown as Popularity was outdated. Now it should be fixed.\n- [x] Prevents reseting of Popularity scores in other fields.\n- [x] Functional tests in\n`test/functional/apps/discover/group6/_sidebar.ts` and\n`test/functional/apps/management/data_views/_index_pattern_popularity.ts`.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"97260415030a3b816b3a8507c51c4a5184ff25df","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data Views","v9.0.0","Team:DataDiscovery","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0"],"title":"[Data View Field] Fix popularity score bugs ","number":211201,"url":"https://github.com/elastic/kibana/pull/211201","mergeCommit":{"message":"[Data View Field] Fix popularity score bugs (#211201)\n\n- Fixes https://github.com/elastic/kibana/issues/211109\n\n## Summary\n\nThis PR fixes a number of bugs in fields popularity logic:\n- [x] If field popularity was customized via UI form, the value will be\nsaved now as a number instead of a string\n- [x] Same for runtime fields in another part of the code\n- [x] Since the data was polluted with string values, this PR makes sure\nthat the incrementing would still work and the result would be converted\nto number.\n- [x] If user opened the field flyout, when selected/deselected fields\nas columns in the table, then opened the field flyout again, the data\nshown as Popularity was outdated. Now it should be fixed.\n- [x] Prevents reseting of Popularity scores in other fields.\n- [x] Functional tests in\n`test/functional/apps/discover/group6/_sidebar.ts` and\n`test/functional/apps/management/data_views/_index_pattern_popularity.ts`.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"97260415030a3b816b3a8507c51c4a5184ff25df"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.17","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211201","number":211201,"mergeCommit":{"message":"[Data View Field] Fix popularity score bugs (#211201)\n\n- Fixes https://github.com/elastic/kibana/issues/211109\n\n## Summary\n\nThis PR fixes a number of bugs in fields popularity logic:\n- [x] If field popularity was customized via UI form, the value will be\nsaved now as a number instead of a string\n- [x] Same for runtime fields in another part of the code\n- [x] Since the data was polluted with string values, this PR makes sure\nthat the incrementing would still work and the result would be converted\nto number.\n- [x] If user opened the field flyout, when selected/deselected fields\nas columns in the table, then opened the field flyout again, the data\nshown as Popularity was outdated. Now it should be fixed.\n- [x] Prevents reseting of Popularity scores in other fields.\n- [x] Functional tests in\n`test/functional/apps/discover/group6/_sidebar.ts` and\n`test/functional/apps/management/data_views/_index_pattern_popularity.ts`.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"97260415030a3b816b3a8507c51c4a5184ff25df"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> |
||
|---|---|---|
| .. | ||
| apps | ||
| firefox | ||
| fixtures | ||
| page_objects | ||
| screenshots/baseline | ||
| services | ||
| config.base.js | ||
| config.ccs.ts | ||
| config.edge.js | ||
| ftr_provider_context.ts | ||
| jest.config.js | ||
| README.md | ||
Kibana Functional Testing
See our Functional Testing Guide