mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 10:40:07 -04:00
1b25685667
Closes https://github.com/elastic/kibana/issues/216096 ## Summary This PR accomplishes two main things: 1. It flattens out how grid elements are rendered, which means that embeddables no longer re-mount when dragged between sections and 2. It allows panels and sections to be "intermixed" on a **single** level (i.e. you can only drop a section header between panels if they are **not** in a section) Since this was a **major** rewrite of the grid layout logic, I also took some time to clean up the code - this includes removing `proposedGridLayout$` (since this added two sources of truth, which was causing issues with the DOM becoming out-of-sync with the layout object; however, this also caused https://github.com/elastic/kibana/issues/220309) and unifying on the use of "section" rather than "row" (since it was confusing that we were using "row" for both the grid row number and the section ID). https://github.com/user-attachments/assets/c5d9aa97-5b14-4f4c-aacf-74055c7d9c33 > [!NOTE] > Reminder that, since collapsible sections aren't available in Dashboard yet, you must test this PR in the `grid` example app (by running Kibana with `yarn start --run-examples`). ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: mbondyra <marta.bondyra@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| public | ||
| kibana.jsonc | ||
| README.md | ||
| tsconfig.json | ||
Grid Example
This plugin is a playground and learning tool that demonstrates the Dashboard layout engine.