mirror of
https://github.com/elastic/kibana.git
synced 2025-04-21 00:13:52 -04:00
13a373b16c
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] remove worker (#218006)](https://github.com/elastic/kibana/pull/218006) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-04-15T16:18:07Z","message":"[ES|QL] remove worker (#218006)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/217923\n\nInvestigations in https://github.com/elastic/kibana/issues/217368 showed\nthat there was basically no performance impact to passing the AST across\na thread boundary. But we also didn't detect a pressing reason to remove\nthe worker.\n\nSince then, however, we noticed another cost associated with the worker:\nit's a hefty Javascript file, even in production builds. In addition, we\nare doing parsing on the main thread _and_ the worker, so the\n`kbn-esql-ast` package is actually being loaded and parsed twice by the\nbrowser, once for the main thread and once for the worker.\n\nThis PR removes our worker. Our parsing associated with validation and\nautocomplete will still be done asynchronously, but on the main thread.\n\nI do not see any regression in perceived performance.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"9b4403b7dc867de1db520e1f9e8ed07f22f41784","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] remove worker","number":218006,"url":"https://github.com/elastic/kibana/pull/218006","mergeCommit":{"message":"[ES|QL] remove worker (#218006)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/217923\n\nInvestigations in https://github.com/elastic/kibana/issues/217368 showed\nthat there was basically no performance impact to passing the AST across\na thread boundary. But we also didn't detect a pressing reason to remove\nthe worker.\n\nSince then, however, we noticed another cost associated with the worker:\nit's a hefty Javascript file, even in production builds. In addition, we\nare doing parsing on the main thread _and_ the worker, so the\n`kbn-esql-ast` package is actually being loaded and parsed twice by the\nbrowser, once for the main thread and once for the worker.\n\nThis PR removes our worker. Our parsing associated with validation and\nautocomplete will still be done asynchronously, but on the main thread.\n\nI do not see any regression in perceived performance.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"9b4403b7dc867de1db520e1f9e8ed07f22f41784"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218006","number":218006,"mergeCommit":{"message":"[ES|QL] remove worker (#218006)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/217923\n\nInvestigations in https://github.com/elastic/kibana/issues/217368 showed\nthat there was basically no performance impact to passing the AST across\na thread boundary. But we also didn't detect a pressing reason to remove\nthe worker.\n\nSince then, however, we noticed another cost associated with the worker:\nit's a hefty Javascript file, even in production builds. In addition, we\nare doing parsing on the main thread _and_ the worker, so the\n`kbn-esql-ast` package is actually being loaded and parsed twice by the\nbrowser, once for the main thread and once for the worker.\n\nThis PR removes our worker. Our parsing associated with validation and\nautocomplete will still be done asynchronously, but on the main thread.\n\nI do not see any regression in perceived performance.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"9b4403b7dc867de1db520e1f9e8ed07f22f41784"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|---|---|---|
| .. | ||
| bfetch_explorer | ||
| content_management_examples | ||
| controls_example | ||
| data_view_field_editor_example | ||
| developer_examples | ||
| discover_customization_examples | ||
| embeddable_examples | ||
| error_boundary | ||
| eso_model_version_example | ||
| esql_ast_inspector | ||
| esql_validation_example | ||
| expressions_explorer | ||
| feature_control_examples | ||
| feature_flags_example | ||
| field_formats_example | ||
| files_example | ||
| grid_example | ||
| guided_onboarding_example | ||
| hello_world | ||
| locator_examples | ||
| locator_explorer | ||
| partial_results_example | ||
| portable_dashboards_example | ||
| preboot_example | ||
| resizable_layout_examples | ||
| response_stream | ||
| routing_example | ||
| screenshot_mode_example | ||
| search_examples | ||
| share_examples | ||
| state_containers_examples | ||
| ui_action_examples | ||
| ui_actions_explorer | ||
| unified_doc_viewer | ||
| unified_field_list_examples | ||
| user_profile_examples | ||
| v8_profiler_examples | ||
| README.asciidoc | ||
[[example-plugins]] == Example plugins This folder contains example plugins. To run the plugins in this folder, use the `--run-examples` flag (without a basepath), via [source,bash] ---- yarn start --run-examples ----