mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
7260564f6a
## Summary This PR fixes the missing highlight theme for HJSON specs in Vega. The issue https://github.com/elastic/kibana/issues/205711 was caused by https://github.com/elastic/kibana/pull/182348 that inadvertently specified the code-editor package as sideEffect free. This cause the compiler to exclude every import without exported and used methods. This was the case for the code-editor that registered some language highlighters in that way. The solution adopted here is to mark the register_language.ts file as a file with side effects, the alternative solution can be to register these directly from within the code_editor component. A third option is to move these registration within the monaco package where other languages are also registered. I'd like to leave to @elastic/appex-sharedux the preference to followup with a better fix for the future. I'd also like to have the opinion from @elastic/kibana-operations because the misconfigured package issue can be seen only in production and not in development mode. Is it possible that webpack doesn't apply treeshaking when in development mode? fix https://github.com/elastic/kibana/issues/205711 Should also fix the same issue but for TSVB Markdown The fix was tested on CI by running at first only the CI FT with the `sideEffects:false` to verify the failure (see [build](https://buildkite.com/elastic/kibana-pull-request/builds/272375)) and then with the fix specifying the actual file that contains side effects. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| accessibility | ||
| analytics | ||
| api_integration | ||
| common | ||
| examples | ||
| functional | ||
| harden | ||
| health_gateway | ||
| interactive_setup_api_integration | ||
| interactive_setup_functional | ||
| interpreter_functional | ||
| node_roles_functional | ||
| package | ||
| plugin_functional | ||
| scripts | ||
| server_integration | ||
| ui_capabilities/newsfeed_err | ||
| kibana.jsonc | ||
| tsconfig.json | ||