github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/packages/core/rendering/core-rendering-server-internal
History
Exact
Maja Grubic 3592cebe6e
[Custom Branding] Fetch custom branding on unauthenticated pages (#149207) 
## Summary
Addresses: https://github.com/elastic/kibana/issues/148898

This PR adds custom branding to the login page. In order to do so,
`customBranding` plugin utilizes the saved object client with
`SECURITY_EXTENSION_ID` excluded. This PR also adds the appropriate
license check for fetching of custom branding.


I've also added some minor fixes to `template.tsx` and
`loading_indicator.tsx` as there were some errors in the logic and the
places that I've missed in the first iteration.

### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
~- [X] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [X] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-01-31 10:01:35 +01:00
..
src [Custom Branding] Fetch custom branding on unauthenticated pages (#149207) 2023-01-31 10:01:35 +01:00
index.ts Migrate server-side rendering service to packages (#141902) 2022-10-03 00:52:17 -07:00
jest.config.js Migrate server-side rendering service to packages (#141902) 2022-10-03 00:52:17 -07:00
kibana.jsonc Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
package.json Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
README.md Migrate server-side rendering service to packages (#141902) 2022-10-03 00:52:17 -07:00
tsconfig.json [SharedUX] Custom branding service (#148273) 2023-01-11 15:28:10 +01:00

README.md

@kbn/core-rendering-server-internal

This package contains the internal types and implementation for Core's server-side rendering service.