mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
069550d72a
## Summary Fixes: https://github.com/elastic/kibana/issues/149347 This PR replaces deprecated `uiSettings` client with `settings.client` in `useUiSetting` hook. As a result, all consumers of the hook need to provide `settings` service to Kibana context. The majority of this PR is providing the `settings` as a dependency to affected plugins. It would be great if sometime in the future we could get rid of `uiSettings` entirely. `CodeEditor` is one of the components relying on this hook, which caused a lot of the changes in this PR. If you have been tagged for review it means your code is using `useUiSetting` hook directly, or is consuming `CodeEditor` component. I have been focused on updating plugins that had failing functional tests, but would appreciate a manual pass on this as well. xoxo ### Checklist Delete any items that are not applicable to this PR. ~ [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~ ~- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ~- [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ ~- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ ~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ ~- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ ~- [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Maja Grubic <maja.grubic@elastic.co> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License
|
|
* 2.0; you may not use this file except in compliance with the Elastic License
|
|
* 2.0.
|
|
*/
|
|
|
|
import type {
|
|
ApplicationStart,
|
|
ChromeStart,
|
|
DocLinksStart,
|
|
HttpSetup,
|
|
I18nStart,
|
|
IUiSettingsClient,
|
|
NotificationsStart,
|
|
OverlayStart,
|
|
SavedObjectsStart,
|
|
ThemeServiceStart,
|
|
} from '@kbn/core/public';
|
|
import type { SavedObjectsStart as SavedObjectsPluginStart } from '@kbn/saved-objects-plugin/public';
|
|
import type { DataPublicPluginStart } from '@kbn/data-plugin/public';
|
|
import type { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public';
|
|
import type { ScopedHistory } from '@kbn/core/public';
|
|
import type { SharePluginStart } from '@kbn/share-plugin/public';
|
|
import type { SpacesPluginStart } from '@kbn/spaces-plugin/public';
|
|
import type { UnifiedSearchPublicPluginStart } from '@kbn/unified-search-plugin/public';
|
|
|
|
import { useKibana } from '@kbn/kibana-react-plugin/public';
|
|
import type { Storage } from '@kbn/kibana-utils-plugin/public';
|
|
|
|
import type { TriggersAndActionsUIPublicPluginStart } from '@kbn/triggers-actions-ui-plugin/public';
|
|
import type { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';
|
|
import { ChartsPluginStart } from '@kbn/charts-plugin/public';
|
|
import type { FieldFormatsStart } from '@kbn/field-formats-plugin/public';
|
|
import { SavedObjectsManagementPluginStart } from '@kbn/saved-objects-management-plugin/public';
|
|
import type { SettingsStart } from '@kbn/core-ui-settings-browser';
|
|
import type { GetMlSharedImportsReturnType } from '../shared_imports';
|
|
|
|
export interface AppDependencies {
|
|
application: ApplicationStart;
|
|
charts: ChartsPluginStart;
|
|
chrome: ChromeStart;
|
|
data: DataPublicPluginStart;
|
|
dataViews: DataViewsPublicPluginStart;
|
|
docLinks: DocLinksStart;
|
|
fieldFormats: FieldFormatsStart;
|
|
http: HttpSetup;
|
|
i18n: I18nStart;
|
|
notifications: NotificationsStart;
|
|
uiSettings: IUiSettingsClient;
|
|
savedObjects: SavedObjectsStart;
|
|
storage: Storage;
|
|
overlays: OverlayStart;
|
|
theme: ThemeServiceStart;
|
|
history: ScopedHistory;
|
|
savedObjectsPlugin: SavedObjectsPluginStart;
|
|
share: SharePluginStart;
|
|
ml: GetMlSharedImportsReturnType;
|
|
spaces?: SpacesPluginStart;
|
|
triggersActionsUi: TriggersAndActionsUIPublicPluginStart;
|
|
unifiedSearch: UnifiedSearchPublicPluginStart;
|
|
usageCollection?: UsageCollectionStart;
|
|
savedObjectsManagement: SavedObjectsManagementPluginStart;
|
|
settings: SettingsStart;
|
|
}
|
|
|
|
export const useAppDependencies = () => {
|
|
return useKibana().services as AppDependencies;
|
|
};
|
|
|
|
export const useToastNotifications = () => {
|
|
const {
|
|
notifications: { toasts: toastNotifications },
|
|
} = useAppDependencies();
|
|
return toastNotifications;
|
|
};
|