mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 10:40:07 -04:00
50a4fc4916
## Summary This PR removes all imports of Route from react-router-dom and '@kbn/kibana-react-plugin/public' and instead imports Route from @kbn/shared-ux-router. ### Context Based on https://github.com/elastic/kibana/issues/132629#issue-1243243678 This PR executes steps 2 - 4: > 2. To make the transition easier, we want to re-export other react-router-dom exports alongside the modified' Route'. > 3. Solutions should start using that Route component in place of the one from react-router-dom. I.e. replace all occurrences of import { ... } from 'react-router-dom' with import { ... } from '@kbn/shared-ux-router'. > 4. All manual calls to useExecutionContext are not needed anymore and should be removed. ### Future PR Looks like this might be getting worked on in: https://github.com/elastic/kibana/pull/145863 (thanks!) > Introduce an ESlint rule that ensures that react-router-dom is not used directly in Kibana and that imports go through the new @kbn/shared-ux-router package. This is tangentially accomplished through https://github.com/elastic/kibana/pull/150340 but only addresses using Route through @kbn/kibana-react-plugin/public' ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
23 lines
439 B
JSON
23 lines
439 B
JSON
{
|
|
"extends": "../../tsconfig.base.json",
|
|
"compilerOptions": {
|
|
"outDir": "target/types",
|
|
},
|
|
"include": [
|
|
"index.ts",
|
|
"public/**/*.ts",
|
|
"public/**/*.tsx",
|
|
"server/**/*.ts",
|
|
"../../typings/**/*",
|
|
],
|
|
"exclude": [
|
|
"target/**/*",
|
|
],
|
|
"kbn_references": [
|
|
"@kbn/core",
|
|
"@kbn/developer-examples-plugin",
|
|
"@kbn/bfetch-plugin",
|
|
"@kbn/kibana-react-plugin",
|
|
"@kbn/shared-ux-router",
|
|
]
|
|
}
|