mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 10:40:07 -04:00
304cb256cf
## Summary
close https://github.com/elastic/kibana/issues/161545
close https://github.com/elastic/kibana/issues/153257
This PR makes `SavedObjectFinder` component backward compatible. It is
achieved by going through content- management layer, more technical
details
[here](https://docs.google.com/document/d/1ssYmqSEUPrsuCR4iz8DohkEWekoYrm2yL4QR_fVxXLg/edit)
### Testing
`SavedObjectFinder` is this component that allows to pick a saved object
(supports: `search` `index-pattern` `map` `visualization` `lens`
`event-annotation-group`:
It is used in the following places:
- Dashboard
- Add panel
- Replace panel
- Discover - Open Search
- Visualization - Select search as a source for new viz
- Graph - select source
- Cases - markdown editor add lens
- ML (3 places)
- Canvas - select embeddable panel
- Transform
- Lens > select event annotation
### Risks / Follow up
The `SavedObjectFinder` should stay mostly the same, the only notable
functional change is that now `SavedObjectFinder` doesn't support
`includeFields` which allowed partial saved object returns, this was
done to make the call backward-compatible without making the system even
more complicated as otherwise we'll need a way to abstract
`includeFields` from so attributes and allow to run migrations on it
before making a search. follow up issue to bring it back
https://github.com/elastic/kibana/issues/163043
The risk with that is that some client that have a lot of large objects
might run into performance issues when using `SavedObjectFinder`. This
can be mitigated by changing listing limit in advanced setting from
default 1000 to something lower
18 lines
473 B
JSON
18 lines
473 B
JSON
{
|
|
"type": "plugin",
|
|
"id": "@kbn/content-management-examples-plugin",
|
|
"owner": "@elastic/appex-sharedux",
|
|
"description": "Example plugin integrating with content management plugin",
|
|
"plugin": {
|
|
"id": "contentManagementExamples",
|
|
"server": true,
|
|
"browser": true,
|
|
"requiredPlugins": [
|
|
"contentManagement",
|
|
"developerExamples",
|
|
"kibanaReact",
|
|
"savedObjectsTaggingOss"
|
|
],
|
|
"requiredBundles": ["savedObjectsFinder"]
|
|
}
|
|
}
|