github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 10:40:07 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/packages/kbn-event-annotation-components
History
Drew Tate 172de682c5
[Event annotations] Individual annotation editing from library (#163346) 
## Summary

Resolve https://github.com/elastic/kibana/issues/158774
Part of https://github.com/elastic/kibana/issues/159053

<img width="1920" alt="Screenshot 2023-09-13 at 2 00 25 PM"
src="69cfe07e-d442-462b-91c5-395d6040c383">

<img width="1920" alt="Screenshot 2023-09-13 at 2 00 09 PM"
src="260aedbe-31d0-415a-b387-10a9b13bf9a6">

<img width="1920" alt="Screenshot 2023-09-13 at 2 01 07 PM"
src="9672010b-d49b-4041-acf1-33d3baec1e9a">


### Known issues
- [ ] ~Responsive layout~ **Proposal:** don't optimize for mobile
- [x] Recovering embeddable from problematic data view state
- [x] margin around dimension buttons
- [x] Functional test coverage

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2023-09-20 10:09:17 +03:00
..
components [Event annotations] Individual annotation editing from library (#163346) 2023-09-20 10:09:17 +03:00
constants.ts [Lens][Event annotations] Move logic into packages (#161500) 2023-07-19 09:46:57 -05:00
index.ts [Event annotations] Individual annotation editing from library (#163346) 2023-09-20 10:09:17 +03:00
jest.config.js [Event annotations] Individual annotation editing from library (#163346) 2023-09-20 10:09:17 +03:00
kibana.jsonc [Lens][Event annotations] Move logic into packages (#161500) 2023-07-19 09:46:57 -05:00
package.json [Lens][Event annotations] Move logic into packages (#161500) 2023-07-19 09:46:57 -05:00
README.md [Lens][Event annotations] Move logic into packages (#161500) 2023-07-19 09:46:57 -05:00
tsconfig.json [Event annotations] Individual annotation editing from library (#163346) 2023-09-20 10:09:17 +03:00
types.ts Make SavedObjectFinder backward compatible (#162904) 2023-08-08 13:10:29 +02:00

README.md

@kbn/event-annotation-components

A collection of static components used for interacting with event annotations.