mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
- Closes https://github.com/elastic/kibana/issues/155216 ## Summary This PR replaces shard falures toasts with inline warnings in Discover. - [x] Intercept shard failures in Discover main app - [x] Show inline warnings above the grid instead - [x] Handle NoResultsFound case too - [x] Implement for Discover context app - [x] Implement for saved search embeddable on Dashboard - [x] Can we inline timeouts too? - [x] Check SQL view - [x] Add tests Discover view with shard failures <img width="400" alt="Screenshot 2023-07-06 at 14 23 48" src="a0799aa0
-9d2e-42ee-b89b-e0e1180220a5"> Discover view with shard failures (and no results) <img width="400" alt="Screenshot 2023-07-07 at 13 24 50" src="28dc2bad
-9776-4aa9-8f51-219d1c87487a"> Dashboard view with shard failures <img width="400" alt="Screenshot 2023-07-06 at 16 15 49" src="2a68c19a
-1ca8-4f10-a9f5-4aa56f9160b0"> Surrounding documents view with shard failures <img width="400" alt="Screenshot 2023-07-10 at 17 26 31" src="ade63cfe
-a1c2-4c22-8823-58dcfef9357f"> Discover view with timeouts <img width="400" alt="Screenshot 2023-07-07 at 16 47 27" src="0101be19
-a555-4f96-b963-7fe418d51fb5"> Dashboard view with timeouts <img width="400" alt="Screenshot 2023-07-07 at 16 48 18" src="82979365
-4129-4385-8a13-9c139e1acbf1"> Surrounding documents view with timeouts <img width="400" alt="Screenshot 2023-07-11 at 15 03 41" src="0ea41b79
-ac6b-4456-9cfa-0d038b10da7d"> ## Testing For testing please uncomment3f102cf688/src/plugins/data/common/search/search_source/search_source.ts (L922)
or3f102cf688/src/plugins/data/common/search/search_source/search_source.ts (L547)
and switch to `kibana*` data view. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Davis McPhee <davismcphee@hotmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
13 lines
482 B
JavaScript
13 lines
482 B
JavaScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License
|
|
* 2.0 and the Server Side Public License, v 1; you may not use this file except
|
|
* in compliance with, at your election, the Elastic License 2.0 or the Server
|
|
* Side Public License, v 1.
|
|
*/
|
|
|
|
module.exports = {
|
|
preset: '@kbn/test',
|
|
rootDir: '../..',
|
|
roots: ['<rootDir>/packages/kbn-search-response-warnings'],
|
|
};
|