mirror of
https://github.com/elastic/kibana.git
synced 2025-04-25 02:09:32 -04:00
ee26923aab
**Bug**
Calling `/api/osquery/saved_queries` with `sortOrder` but without `sort`
field (`/api/osquery/saved_queries?sortOrder=desc`) was causing 500
server error. Same with calls without any parameters
(`/api/osquery/saved_queries`)
**Cause**
We had defaults failover set for `sortOrder` but not for `sort`. Sorting
logic required both fields to be defined. All schema params were set to
optional and we were validating them ourselves.
**Fix**
I've tightened the schema by making all the params required and provided
default values if not provided.
`page: schema.number({ defaultValue: 1 }),
sort: schema.string({ defaultValue: 'id' }),
sortOrder: schema.oneOf([schema.literal('asc'), schema.literal('desc')],
{defaultValue: 'desc',}),`
**Additionally**
Outdated osQuery API docs - `perPage` became `pageSize` and `sortField`
became `sort`. Also, minor spelling fixes.
---------
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
|
||
|---|---|---|
| .. | ||
| actions-and-connectors | ||
| alerting | ||
| cases | ||
| dashboard | ||
| data-views | ||
| index-patterns | ||
| logstash-configuration-management | ||
| machine-learning | ||
| osquery-manager | ||
| role-management | ||
| saved-objects | ||
| session-management | ||
| short-urls | ||
| spaces-management | ||
| task-manager | ||
| upgrade-assistant | ||
| actions-and-connectors.asciidoc | ||
| alerting.asciidoc | ||
| cases.asciidoc | ||
| dashboard-api.asciidoc | ||
| data-views.asciidoc | ||
| features.asciidoc | ||
| index-patterns.asciidoc | ||
| logstash-configuration-management.asciidoc | ||
| machine-learning.asciidoc | ||
| osquery-manager.asciidoc | ||
| role-management.asciidoc | ||
| saved-objects.asciidoc | ||
| session-management.asciidoc | ||
| short-urls.asciidoc | ||
| spaces-management.asciidoc | ||
| upgrade-assistant.asciidoc | ||