mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
## Summary This PR removes all imports of Route from react-router-dom and '@kbn/kibana-react-plugin/public' and instead imports Route from @kbn/shared-ux-router. ### Context Based on https://github.com/elastic/kibana/issues/132629#issue-1243243678 This PR executes steps 2 - 4: > 2. To make the transition easier, we want to re-export other react-router-dom exports alongside the modified' Route'. > 3. Solutions should start using that Route component in place of the one from react-router-dom. I.e. replace all occurrences of import { ... } from 'react-router-dom' with import { ... } from '@kbn/shared-ux-router'. > 4. All manual calls to useExecutionContext are not needed anymore and should be removed. ### Future PR Looks like this might be getting worked on in: https://github.com/elastic/kibana/pull/145863 (thanks!) > Introduce an ESlint rule that ensures that react-router-dom is not used directly in Kibana and that imports go through the new @kbn/shared-ux-router package. This is tangentially accomplished through https://github.com/elastic/kibana/pull/150340 but only addresses using Route through @kbn/kibana-react-plugin/public' ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
172 lines
5.7 KiB
TypeScript
172 lines
5.7 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License
|
|
* 2.0; you may not use this file except in compliance with the Elastic License
|
|
* 2.0.
|
|
*/
|
|
|
|
import React from 'react';
|
|
import ReactDOM from 'react-dom';
|
|
import { BrowserRouter as Router } from 'react-router-dom';
|
|
import { Route } from '@kbn/shared-ux-router';
|
|
import { EuiPage, EuiTitle, EuiText, EuiSpacer } from '@elastic/eui';
|
|
import { AppMountParameters, CoreStart } from '@kbn/core/public';
|
|
import { TriggersAndActionsUIPublicPluginStart } from '@kbn/triggers-actions-ui-plugin/public';
|
|
import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
|
|
import { DataPublicPluginStart } from '@kbn/data-plugin/public';
|
|
import { __IntlProvider as IntlProvider } from '@kbn/i18n-react';
|
|
import { TriggersActionsUiExamplePublicStartDeps } from './plugin';
|
|
|
|
import { Page } from './components/page';
|
|
import { Sidebar } from './components/sidebar';
|
|
|
|
import { RulesListSandbox } from './components/rules_list_sandbox';
|
|
import { RulesListNotifyBadgeSandbox } from './components/rules_list_notify_badge_sandbox';
|
|
import { RuleTagBadgeSandbox } from './components/rule_tag_badge_sandbox';
|
|
import { RuleTagFilterSandbox } from './components/rule_tag_filter_sandbox';
|
|
import { RuleEventLogListSandbox } from './components/rule_event_log_list_sandbox';
|
|
import { RuleStatusDropdownSandbox } from './components/rule_status_dropdown_sandbox';
|
|
import { RuleStatusFilterSandbox } from './components/rule_status_filter_sandbox';
|
|
import { AlertsTableSandbox } from './components/alerts_table_sandbox';
|
|
import { RulesSettingsLinkSandbox } from './components/rules_settings_link_sandbox';
|
|
|
|
export interface TriggersActionsUiExampleComponentParams {
|
|
http: CoreStart['http'];
|
|
basename: string;
|
|
triggersActionsUi: TriggersAndActionsUIPublicPluginStart;
|
|
data: DataPublicPluginStart;
|
|
}
|
|
|
|
const TriggersActionsUiExampleApp = ({
|
|
basename,
|
|
triggersActionsUi,
|
|
}: TriggersActionsUiExampleComponentParams) => {
|
|
return (
|
|
<Router basename={basename}>
|
|
<EuiPage>
|
|
<Sidebar />
|
|
<Route
|
|
exact
|
|
path="/"
|
|
render={() => (
|
|
<Page title="Home" isHome>
|
|
<EuiTitle size="l">
|
|
<h1>Welcome to the Triggers Actions UI plugin example</h1>
|
|
</EuiTitle>
|
|
<EuiSpacer />
|
|
<EuiText>
|
|
This example plugin displays the shareable components in the Triggers Actions UI
|
|
plugin. It also serves as a sandbox to run functional tests to ensure the shareable
|
|
components are functioning correctly outside of their original plugin.
|
|
</EuiText>
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rules_list"
|
|
render={() => (
|
|
<Page title="Rules List">
|
|
<RulesListSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rules_list_notify_badge"
|
|
render={() => (
|
|
<Page title="Rule List Notify Badge">
|
|
<RulesListNotifyBadgeSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rule_tag_badge"
|
|
render={() => (
|
|
<Page title="Rule Tag Badge">
|
|
<RuleTagBadgeSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rule_tag_filter"
|
|
render={() => (
|
|
<Page title="Rule Tag Filter">
|
|
<RuleTagFilterSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rule_event_log_list"
|
|
render={() => (
|
|
<Page title="Run History List">
|
|
<RuleEventLogListSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rule_status_dropdown"
|
|
render={() => (
|
|
<Page title="Rule Status Dropdown">
|
|
<RuleStatusDropdownSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rule_status_filter"
|
|
render={() => (
|
|
<Page title="Rule Status Filter">
|
|
<RuleStatusFilterSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/alerts_table"
|
|
render={() => (
|
|
<Page title="Alerts Table">
|
|
<AlertsTableSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
<Route
|
|
path="/rules_settings_link"
|
|
render={() => (
|
|
<Page title="Rules Settings Link">
|
|
<RulesSettingsLinkSandbox triggersActionsUi={triggersActionsUi} />
|
|
</Page>
|
|
)}
|
|
/>
|
|
</EuiPage>
|
|
</Router>
|
|
);
|
|
};
|
|
|
|
export const renderApp = (
|
|
core: CoreStart,
|
|
deps: TriggersActionsUiExamplePublicStartDeps,
|
|
{ appBasePath, element }: AppMountParameters
|
|
) => {
|
|
const { http } = core;
|
|
const { triggersActionsUi } = deps;
|
|
const { ruleTypeRegistry, actionTypeRegistry } = triggersActionsUi;
|
|
ReactDOM.render(
|
|
<KibanaContextProvider
|
|
services={{
|
|
...core,
|
|
...deps,
|
|
ruleTypeRegistry,
|
|
actionTypeRegistry,
|
|
}}
|
|
>
|
|
<IntlProvider locale="en">
|
|
<TriggersActionsUiExampleApp
|
|
basename={appBasePath}
|
|
http={http}
|
|
triggersActionsUi={deps.triggersActionsUi}
|
|
data={deps.data}
|
|
/>
|
|
</IntlProvider>
|
|
</KibanaContextProvider>,
|
|
element
|
|
);
|
|
|
|
return () => ReactDOM.unmountComponentAtNode(element);
|
|
};
|