mirror of
https://github.com/elastic/kibana.git
synced 2025-04-25 02:09:32 -04:00
02bafbdf92
## Summary Add the `sideEffects` meta to packages without side effects to optimize tree-shaking on browser-side bundles. Notes: - it mostly impacts the `securitySolution` app (almost 2mb reduction) - it's not always beneficial for all apps, some apps gain some weight, likely related to the way webpack optimizes the chunks, but I feel like it's still overall beneficial (don't hesitate to say if you think otherwise) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| index.ts | ||
| jest.config.js | ||
| kibana.jsonc | ||
| package.json | ||
| README.md | ||
| setup_test.ts | ||
| tsconfig.json | ||
@kbn/securitysolution-exception-list-components
Common exceptions' components
Aim
- To have most of the Exceptions' components in one place, to be shared accross multiple pages and used for different logic.
- This
packageholds the presetational part of the components only as the API or the logic part should reside under the consumer page
Pattern used
component
index.tsx
index.styles.ts <-- to hold styles if the component has many custom styles
use_component.ts <-- for logic if the Presentational Component has logic
component.test.tsx
use_component.test.tsx
Testing
In order to unify our testing tools, we configured only two libraries, the React-Testing-Library to test the component UI part and the Reat-Testing-Hooks to test the component's UI interactions
Styling
In order to follow the KBN-Packages's recommendations, to define a custom CSS we can only use the @emotion/react or @emotion/css libraries
Next
- Now the
ExceptionItems, ExceptionItemCard and ExceptionItemCardMetaInforeceivesecurityLinkAnchorComponent, exceptionsUtilityComponent , and exceptionsUtilityComponentas props to avoid moving all thecommoncomponents under thex-packat once, later we should move all building blocks to thiskbn-package