mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
👋 Hi all - the biggest breaking change of this PR is around two icon type changes/renames. 1. ⚠️ **The `alert` icon is now named `warning`** - <img width="103" alt="" src="https://user-images.githubusercontent.com/549407/223561599-8913e88c-676f-47cd-aaed-81b64783bd81.png" align="middle"> - This change should have been automatically converted on your behalf by the EUI team, **but if for some reason** we missed making this conversion in this PR and your icon(s) are now broken, please ping us or let us know in this PR (or fix yourself after this PR merges). - In some cases, teams were using this icon for error messages, alongside the `danger` color. In those cases, we opinionatedly changed those icon usages to the new `error` icon instead of using the old alert/warning icon. 2. 🛑 **The `crossInACircleFilled` icon has been removed, and a new `error` icon added** - <img width="84" alt="" src="https://user-images.githubusercontent.com/549407/223561892-4406bdf6-1a55-49ac-85ad-3a11eb7c090d.png" align="middle"> - The conversion for this breaking change was not straightforward. This was the path we used to determine what to change `crossInACircleFilled` usages to: - If the icon was associated with errors or error messages, we changed it to the new `error` icon. - If a "delete" action was associated with this icon, we changed it to the `trash` icon instead. - If a "clear" action was associated with this icon, we changed it to just the `cross` icon, or in some cases `minusInCircleFilled` (if used alongside `plusInCircleFilled`). - Again, if we made a mistake during this conversion or missed your plugin, please feel free to ping us. ## Summary `eui@75.1.2` ⏩ `eui@76.0.2` ## [`76.0.2`](https://github.com/elastic/eui/tree/v76.0.2) **Bug fixes** - Added a legacy `alert` alias for the `warning` `EuiIcon` type ([#6640](https://github.com/elastic/eui/pull/6640)) ## [`76.0.1`](https://github.com/elastic/eui/tree/v76.0.1) **Bug fixes** - Fixed broken icons on all `isInvalid` form controls ([#6629](https://github.com/elastic/eui/pull/6629)) ## [`76.0.0`](https://github.com/elastic/eui/tree/v76.0.0) - Added `pivot` glyph to `EuiIcon` ([#6605](https://github.com/elastic/eui/pull/6605)) - Added the `displayHeaderCellProps` API to `EuiDataGrid`'s columns, which allows passing custom props directly to column header cells ([#6609](https://github.com/elastic/eui/pull/6609)) - Added the new `headerCellProps`/`footerCellProps` APIs to `EuiDataGrid`'s control columns, which allows passing custom props directly to control column header or footer cells ([#6609](https://github.com/elastic/eui/pull/6609)) - Added a new `footerCellRender` API to `EuiDataGrid`'s control columns, which allows completely customizing control column rendering (previously rendered an empty cell) ([#6609](https://github.com/elastic/eui/pull/6609)) - Updated the styling of nested ordered lists in `EuiText` to align with GitHub's list style, which is a popular format used in Markdown or MDX formatting ([#6615](https://github.com/elastic/eui/pull/6615)) - Added a margin-bottom property exclusively to the direct child `ul` and `ol` elements of the `EuiText` component ([#6615](https://github.com/elastic/eui/pull/6615)) - Fix issue with badges appearing within an `EuiBadgeGroup`, where the CSS rule to override the `margin-inline-start` was not being applied correctly due to the order of appearance in the CSS rules ([#6618](https://github.com/elastic/eui/pull/6618)) **Bug fixes** - Fixed `EuiDataGrid` footer control columns rendering with cell expansion popovers when they should not have been ([#6609](https://github.com/elastic/eui/pull/6609)) - Fixed an `EuiSkipLink` bug where main content loading in progressively/dynamically after the skip link rendered was not being correctly focused ([#6613](https://github.com/elastic/eui/pull/6613)) **Breaking changes** - Renamed `EuiIcon`'s `alert` to `warning` ([#6608](https://github.com/elastic/eui/pull/6608)) - Removed `EuiIcon`'s `crossInACircleFilled` in favor of `error` ([#6608](https://github.com/elastic/eui/pull/6608)) --------- Co-authored-by: Davey Holler <daveyholler@hey.com> Co-authored-by: Constance Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co> |
||
---|---|---|
.. | ||
avatar | ||
button/exit_full_screen | ||
button_toolbar | ||
card/no_data | ||
code_editor | ||
file | ||
link/redirect_app | ||
markdown | ||
page | ||
prompt | ||
router | ||
storybook | ||
README.mdx |
# Shared UX Packages This directory contains directories of packages of shared components and other code for use in Kibana solutions. ## How to use these components Each package exports one or more components that can be consumed. ### Lazy by default All components are exported to be lazily-loaded with a default `React.Suspense` default most appropriate to its nature. If a solution needs to alter the `React.Suspense` behavior, (e.g. a different "loading" component), one can import the `Lazy[ComponentName]` version and surround it with a custom `React.Suspense` component. ### "Pure" and "Connected" components If a package contains a component with functionality that relies on a Kibana core or plugin dependency, there are two components exported: a `pure` component and a `connected` component. __Pure__ components: - are focused on how a component looks and behaves; - have their props and handlers exposed as simple types; - have no logic specific to Kibana. __Connected__ components, by contrast: - *compose* their pure counterparts; - rely on Kibana core and plugin dependencies to provide Kibana-specific logic; - require a `ContextProvider` packaged with the component to provide stateful services from a start contract. For example, the `ExitFullScreenButton` "pure" component is a button that is styled with the appropriate translated text. It is simple and without dependency. The "connected" component *composes* that pure component and: - applies EUI theme state; - uses the `coreStart.chrome.setIsVisible` API to change the full screen state `onClick`; - applies `emotion` styles to position the button in the window. ### Connected component providers Connected components are accompanied by a `Provider` which is intended to provide their external services. We typically provide two: one that abstracts away the dependency into a simplified set of functions, and one that maps to the intended dependency directly. For example, the `ExitFullScreenButton` relies on the `coreStart.chrome.setIsVisible` API to interact with the full screen state. The package contains two providers. The `ExitFullScreenButtonProvider` simply expects a single function, `setIsFullScreen`. This pattern is useful for more complicated components that may rely on a number of dependencies: ``` <ExitFullScreenButtonProvider setIsFullScreen={...}> <ExitFullScreenButton /> </ExitFullScreenButtonProvider> ``` The `ExitFullScreenButtonKibanaProvider` creates a facsimile of the `coreStart` contract type, containing only the portions it expects to use. This is a kind of "syntactic-sugar-workaround" to the fact plugin start contracts are not typically available to packages: ``` <ExitFullScreenButtonKibanaProvider coreStart={...}> <ExitFullScreenButton /> </ExitFullScreenButtonProvider> ``` Plugins can use either of these providers in their plugin at either the root of their plugin application or at any level of their React tree, wherever it makes sense. Component compositions can do the same. Either Provider can be used, depending on the situation. ## How can I contribute a component? *__Yes, please!__ :elasticheart:* The easiest way to contribute a shared component to Kibana is to follow our pattern and create a single package containing that contribution. You can use the `generate` script to create a new boilerplate package. > More detail on this is coming soon. Contact the Shared UX team for more information. ## How this collection is organized Typically, the `/packages` directory contains a flat list of packages, where each directory matches the name of the package. Given that we expect to create a large number of packages, we're going to organize them into a loose tree structure: ``` - packages - shared-ux - button - exit_full_screen - [component type] - baz - qux - [subject matter] - foo - bar ``` This structure should then map to the name of the package: ``` - @kbn/shared-ux-button-exit-full-screen - @kbn/shared-ux-[subject matter]-[foo] - @kbn/shared-ux-[subject matter]-[bar] - @kbn/shared-ux-[component-type]-[baz] - @kbn/shared-ux-[component-type]-[qux] ``` ## Why? When we started exploring how to effectively share code between Kibana solutions, we realized-- admittedly through some trial and error-- that the usual ways in which we share code between plugins wasn't going to work. ### Why not a plugin? First, with each component that we create, those components inevitably begin to depend on other plugins. Once our plugin depends on another, that plugin then becomes unable to use Shared UX components without creating a circular dependency. Second, the components, while useful to a plugin, are not actually dependent on the *plugin lifecycle*. They are stateless. Containing-- restricting-- them to a plugin lifecycle adds unnecessary complexity. So we opted to organize our code in packages. ### Why not a single package of components? We started that way, and quickly ran into the "`lodash` bundle problem": containing all of our components in one package (and all of our services in another) meant that any plugin using even one component would inherit *all* of them... even if they weren't used. Bundle sizes would increase dramatically, as well as build times: any minor change would cascade through the entire monorepo. Therefore we've opted to create a package for each component. ### How do your components share code? At present, *they don't*. Some utility code is shared, but this is code that should change very rarely, at most. But that doesn't mean they cannot be *composed* together. `ComponentA` can certainly compose `ComponentB` and `ComponentC`. What's great is the dependencies become very clear, top-down, and reflect the granular nature of each component.