github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/examples/content_management_examples
History
Anton Dosov 304cb256cf
Make SavedObjectFinder backward compatible (#162904) 
## Summary

close https://github.com/elastic/kibana/issues/161545
close https://github.com/elastic/kibana/issues/153257

This PR makes `SavedObjectFinder` component backward compatible. It is
achieved by going through content- management layer, more technical
details
[here](https://docs.google.com/document/d/1ssYmqSEUPrsuCR4iz8DohkEWekoYrm2yL4QR_fVxXLg/edit)

### Testing

`SavedObjectFinder` is this component that allows to pick a saved object
(supports: `search` `index-pattern` `map` `visualization` `lens`
`event-annotation-group`:

![Screenshot 2023-08-07 at 16 53
32](5c283ea5-3682-4dc8-a8ff-422e6f4f3195)


It is used in the following places: 

- Dashboard 
  - Add panel
  - Replace panel 
- Discover - Open Search 
- Visualization - Select search as a source for new viz
- Graph - select source
- Cases - markdown editor add lens 
- ML (3 places) 
- Canvas - select embeddable panel 
- Transform 
- Lens > select event annotation 




### Risks / Follow up 

The `SavedObjectFinder` should stay mostly the same, the only notable
functional change is that now `SavedObjectFinder` doesn't support
`includeFields` which allowed partial saved object returns, this was
done to make the call backward-compatible without making the system even
more complicated as otherwise we'll need a way to abstract
`includeFields` from so attributes and allow to run migrations on it
before making a search. follow up issue to bring it back
https://github.com/elastic/kibana/issues/163043

The risk with that is that some client that have a lot of large objects
might run into performance issues when using `SavedObjectFinder`. This
can be mitigated by changing listing limit in advanced setting from
default 1000 to something lower
2023-08-08 13:10:29 +02:00
..
.storybook [CM] Example plugin with server-side registry usage (#151885) 2023-02-28 14:57:57 +01:00
common/examples/todos [CM] Improve CRUD & RPC interfaces (#154150) 2023-04-04 08:20:11 -07:00
public Make SavedObjectFinder backward compatible (#162904) 2023-08-08 13:10:29 +02:00
server [CM] Improve CRUD & RPC interfaces (#154150) 2023-04-04 08:20:11 -07:00
jest.config.js [CM] Example plugin with server-side registry usage (#151885) 2023-02-28 14:57:57 +01:00
kibana.jsonc Make SavedObjectFinder backward compatible (#162904) 2023-08-08 13:10:29 +02:00
README.md [CM] Example plugin with server-side registry usage (#151885) 2023-02-28 14:57:57 +01:00
tsconfig.json Make SavedObjectFinder backward compatible (#162904) 2023-08-08 13:10:29 +02:00

README.md

Content Management Examples

An example plugin that shows how to integrate with the Kibana "content management" plugin.