mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
92fe7f8ab3
This fixes two fundamental issues: * the list of files to be linted is built looking at the diffs of the ref specified with `--ref` (or otherwise the current index) with those on the filesystem * the content to be linted is read from the filesystem instead of the specified `ref` or the one in the index
82 lines
2.7 KiB
JavaScript
82 lines
2.7 KiB
JavaScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License
|
|
* 2.0 and the Server Side Public License, v 1; you may not use this file except
|
|
* in compliance with, at your election, the Elastic License 2.0 or the Server
|
|
* Side Public License, v 1.
|
|
*/
|
|
|
|
import { run, combineErrors, createFlagError, createFailError } from '@kbn/dev-utils';
|
|
import * as Eslint from './eslint';
|
|
import * as Stylelint from './stylelint';
|
|
import { getFilesForCommit, checkFileCasing } from './precommit_hook';
|
|
|
|
run(
|
|
async ({ log, flags }) => {
|
|
const files = await getFilesForCommit(flags.ref);
|
|
const errors = [];
|
|
|
|
const maxFilesCount = flags['max-files']
|
|
? Number.parseInt(String(flags['max-files']), 10)
|
|
: undefined;
|
|
if (maxFilesCount !== undefined && (!Number.isFinite(maxFilesCount) || maxFilesCount < 1)) {
|
|
throw createFlagError('expected --max-files to be a number greater than 0');
|
|
}
|
|
|
|
const virtualFilesCount = files.filter((file) => file.isVirtual()).length;
|
|
if (virtualFilesCount > 0 && virtualFilesCount < files.length) {
|
|
throw createFailError('Mixing of virtual and on-filesystem files is unsupported');
|
|
}
|
|
|
|
if (maxFilesCount && files.length > maxFilesCount) {
|
|
log.warning(
|
|
`--max-files is set to ${maxFilesCount} and ${files.length} were discovered. The current script execution will be skipped.`
|
|
);
|
|
return;
|
|
}
|
|
|
|
try {
|
|
await checkFileCasing(log, files);
|
|
} catch (error) {
|
|
errors.push(error);
|
|
}
|
|
|
|
for (const Linter of [Eslint, Stylelint]) {
|
|
const filesToLint = Linter.pickFilesToLint(log, files);
|
|
if (filesToLint.length > 0) {
|
|
try {
|
|
await Linter.lintFiles(log, filesToLint, {
|
|
fix: flags.fix,
|
|
});
|
|
} catch (error) {
|
|
errors.push(error);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (errors.length) {
|
|
throw combineErrors(errors);
|
|
}
|
|
},
|
|
{
|
|
description: `
|
|
Run checks on files that are staged for commit by default
|
|
`,
|
|
flags: {
|
|
boolean: ['fix'],
|
|
string: ['max-files', 'ref'],
|
|
default: {
|
|
fix: false,
|
|
},
|
|
help: `
|
|
--fix Execute eslint in --fix mode
|
|
--max-files Max files number to check against. If exceeded the script will skip the execution
|
|
--ref Run checks against git ref files instead of running against staged ones
|
|
Examples:
|
|
HEAD~1..HEAD files changed in the commit at HEAD
|
|
HEAD equivalent to HEAD~1..HEAD
|
|
main... files changed in current branch since the common ancestor with main
|
|
`,
|
|
},
|
|
}
|
|
);
|