kibana/src
Kibana Machine 137a71bf35
[8.17] [Inspector]: fix pagination not working (#223537) (#224214)
# Backport

This will backport the following commits from `main` to `8.17`:
- [[Inspector]: fix pagination not working
(#223537)](https://github.com/elastic/kibana/pull/223537)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-06-17T10:33:38Z","message":"[Inspector]:
fix pagination not working (#223537)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/223536\n\nIt wasn't possible to
change the page index in the Inspector Data View.\nThe table was using
the `onTableChange` callback, coming from the\n`useEuiTablePersist` hook
in the wrapping function, in the `onChange`\nprop of the `EuiTable`
instead of being attached to the `onTableChange`\nprop.\n\nWhen using
the `onChange` the EuiTable leave all the pagination/size etc\nhandling
to the consumer, where the `onTableChange` is just a callback\nrelated
to the changes, used within the `useEuiTablePersist` to store\nsome
configuration across tabels.\n\nThe PR fixes the `onTableChange`
callback to the correct prop.\n\nA functional test was also added to
check the pagination works within\nLens. I haven't used the existing
`inspector.ts` functional tests\nbecause they where within the Legacy
Visualize.\n\nI've checked the usage of `useEuiTablePersist` and the
returned\n`onTableChange` and is correctly used everywhere except for
ESQL query\nhistory that doesn't seems to have enabled pagination cc
@stratoula\n\n90f65c3dba/src/platform/packages/private/kbn-esql-editor/src/editor_footer/history_starred_queries.tsx (L383)\n\n---------\n\nCo-authored-by:
Marco Liberati
<dej611@users.noreply.github.com>","sha":"d4fb29bb2deac21fa88ffb0e69f7ecd0d6baf4f4","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","regression","release_note:fix","Team:Visualizations","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Inspector]:
fix pagination not
working","number":223537,"url":"https://github.com/elastic/kibana/pull/223537","mergeCommit":{"message":"[Inspector]:
fix pagination not working (#223537)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/223536\n\nIt wasn't possible to
change the page index in the Inspector Data View.\nThe table was using
the `onTableChange` callback, coming from the\n`useEuiTablePersist` hook
in the wrapping function, in the `onChange`\nprop of the `EuiTable`
instead of being attached to the `onTableChange`\nprop.\n\nWhen using
the `onChange` the EuiTable leave all the pagination/size etc\nhandling
to the consumer, where the `onTableChange` is just a callback\nrelated
to the changes, used within the `useEuiTablePersist` to store\nsome
configuration across tabels.\n\nThe PR fixes the `onTableChange`
callback to the correct prop.\n\nA functional test was also added to
check the pagination works within\nLens. I haven't used the existing
`inspector.ts` functional tests\nbecause they where within the Legacy
Visualize.\n\nI've checked the usage of `useEuiTablePersist` and the
returned\n`onTableChange` and is correctly used everywhere except for
ESQL query\nhistory that doesn't seems to have enabled pagination cc
@stratoula\n\n90f65c3dba/src/platform/packages/private/kbn-esql-editor/src/editor_footer/history_starred_queries.tsx (L383)\n\n---------\n\nCo-authored-by:
Marco Liberati
<dej611@users.noreply.github.com>","sha":"d4fb29bb2deac21fa88ffb0e69f7ecd0d6baf4f4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223537","number":223537,"mergeCommit":{"message":"[Inspector]:
fix pagination not working (#223537)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/223536\n\nIt wasn't possible to
change the page index in the Inspector Data View.\nThe table was using
the `onTableChange` callback, coming from the\n`useEuiTablePersist` hook
in the wrapping function, in the `onChange`\nprop of the `EuiTable`
instead of being attached to the `onTableChange`\nprop.\n\nWhen using
the `onChange` the EuiTable leave all the pagination/size etc\nhandling
to the consumer, where the `onTableChange` is just a callback\nrelated
to the changes, used within the `useEuiTablePersist` to store\nsome
configuration across tabels.\n\nThe PR fixes the `onTableChange`
callback to the correct prop.\n\nA functional test was also added to
check the pagination works within\nLens. I haven't used the existing
`inspector.ts` functional tests\nbecause they where within the Legacy
Visualize.\n\nI've checked the usage of `useEuiTablePersist` and the
returned\n`onTableChange` and is correctly used everywhere except for
ESQL query\nhistory that doesn't seems to have enabled pagination cc
@stratoula\n\n90f65c3dba/src/platform/packages/private/kbn-esql-editor/src/editor_footer/history_starred_queries.tsx (L383)\n\n---------\n\nCo-authored-by:
Marco Liberati
<dej611@users.noreply.github.com>","sha":"d4fb29bb2deac21fa88ffb0e69f7ecd0d6baf4f4"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2025-06-17 14:44:35 +02:00
..
cli [8.17] Upgrade Node.js to 20.19.2 (#221177) (#223137) 2025-06-09 16:36:39 -05:00
cli_encryption_keys Adds AGPL 3.0 license (#192025) 2024-09-06 19:02:41 -06:00
cli_health_gateway Adds AGPL 3.0 license (#192025) 2024-09-06 19:02:41 -06:00
cli_keystore Adds AGPL 3.0 license (#192025) 2024-09-06 19:02:41 -06:00
cli_plugin Adds AGPL 3.0 license (#192025) 2024-09-06 19:02:41 -06:00
cli_setup Adds AGPL 3.0 license (#192025) 2024-09-06 19:02:41 -06:00
cli_verification_code Adds AGPL 3.0 license (#192025) 2024-09-06 19:02:41 -06:00
core chore(NA): bump version to 8.17.8 (#222417) 2025-06-03 21:39:28 +01:00
dev [8.17] [Build] Fix parallel stderr (#223177) (#223484) 2025-06-12 08:24:54 -05:00
platform/plugins/shared/home/public/assets/elasticsearch_logs [8.17] adds thumbnail for elasticsearch logs integration (#212877) (#212907) 2025-03-03 14:58:40 +00:00
plugins [8.17] [Inspector]: fix pagination not working (#223537) (#224214) 2025-06-17 14:44:35 +02:00
setup_node_env [8.17] Additional prototype pollution protections (#206073) (#216286) 2025-04-04 20:52:26 +02:00