github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/src
History
Nathan Reese f2ad024082
[lens] show 'View details' UI action to open clusters inspector tab when request fails (#172971) 
Closes https://github.com/elastic/kibana/issues/171570

PR make the following changes
1. Consolidates data EsError logic and Lens EsError logic. This resulted
in being able to remove large parts of lens error_helper.tsx file.
2. Consolidates lens WorkspacePanel error logic. Before PR configuration
errors and data loading errors each rendered their own version of
EuiEmptyPrompt with slightly different behavior. Now, both render
WorkspaceErrors component and have the same behavior
3. Updated lens ExpressionWrapper to return original error to embeddable
output.

### Test - EsError in embeddable
1. install sample web logs
2. create new dashboard
3. Click "Create visualization"
4. Drag "timestamp" field into workspace.
5. Click "Save and return"
6. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "local shard failure message 123",
            "name": "kibana_sample_data_logs"
          }
        ]
      }
    }
    ```
7. Verify EsError and "View details" action are displayed
<img width="500" alt="Screenshot 2023-12-08 at 1 34 20 PM"
src="1c65b7f3-ece7-4000-a5b2-11127cc38f01">

### Test - multiple configuration errors in lens editor
1. install sample web logs
2. create new lens visualization
3. Drag "timestamp" field into workspace.
4. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "local shard failure message 123",
            "name": "kibana_sample_data_logs"
          }
        ]
      }
    }
    ```
5. Verify EsError and "View details" action are displayed
<img width="500" alt="Screenshot 2023-12-08 at 1 09 22 PM"
src="22023512-d344-4f99-abbd-8427d764f821">

### Test - EsError in embeddable
1. install sample web logs
2. create new dashboard
3. Click "Create visualization"
4. Drag "timestamp" field into workspace.
5. Change "Vertical axis" to "Cumulative sum". Select "Field" select and
hit delete key
6. Clone layer one or more times
7. Verify pagination is displayed, allowing users to click through all
configuration errors
<img width="500" alt="Screenshot 2023-12-08 at 12 59 18 PM"
src="6302658a-8cf7-4a1a-a117-ae810c0af539">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2023-12-20 15:12:54 -07:00
..
cli Update dependency elastic-apm-node to ^4.2.0 (main) (#172308) 2023-12-01 15:28:37 +01:00
cli_encryption_keys Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
cli_health_gateway Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
cli_keystore Bump jest@29.6.1 (#161630) 2023-07-15 17:42:30 +02:00
cli_plugin Remove a unnecessary argument (#150268) 2023-02-07 08:58:10 -06:00
cli_setup [Elasticsearch] Log queued requests (#152571) 2023-03-06 14:25:44 +01:00
cli_verification_code Transpile packages on demand, validate all TS projects (#146212) 2022-12-22 19:00:29 -06:00
core [Cloud Security] Mute CSP Benchmark Rules 2023-12-18 14:34:19 +02:00
dev Upgrade EUI to v91.0.0 (with backports) (#170716) 2023-12-18 11:15:15 -06:00
plugins [lens] show 'View details' UI action to open clusters inspector tab when request fails (#172971) 2023-12-20 15:12:54 -07:00
setup_node_env Disable rison parsing error logs in production (#171660) 2023-11-22 10:46:55 +01:00