kibana/test/api_integration/apis/guided_onboarding/get_state.ts
Christiane (Tina) Heiligers 3a68f8b3ae
[http] api_integration tests handle internal route restriction (#192407)
fix https://github.com/elastic/kibana/issues/192052
## Summary

Internal APIs will be
[restricted](https://github.com/elastic/kibana/issues/163654) from
public access as of 9.0.0. In non-serverless environments, this breaking
change will result in a 400 error if an external request is made to an
internal Kibana API (route `access` option as `"internal"` or
`"public"`).
This PR allows API owners of non-xpack plugins to run their `ftr` API
integration tests against the restriction and adds examples of how to
handle it.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


Note to reviewers: The header needed to allow access to internal apis
shouldn't change your test output, with or without the restriction
enabled.

### How to test the changes work:
#### Non x-pack:
1. Set `server.restrictInternalApis: true` in `test/common/config.js`
2. Ensure your tests pass

#### x-pack:
1. Set `server.restrictInternalApis: true` in
`x-pack/test/api_integration/apis/security/config.ts`
2. Ensure the spaces tests pass

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2024-09-12 09:23:10 +02:00

150 lines
5.1 KiB
TypeScript

/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the "Elastic License
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
* Public License v 1"; you may not use this file except in compliance with, at
* your election, the "Elastic License 2.0", the "GNU Affero General Public
* License v3.0 only", or the "Server Side Public License, v 1".
*/
import expect from '@kbn/expect';
import {
testGuideStep1ActiveState,
testGuideNotActiveState,
mockPluginStateNotStarted,
testGuideParams,
} from '@kbn/guided-onboarding-plugin/public/services/api.mocks';
import {
guideStateSavedObjectsType,
pluginStateSavedObjectsType,
} from '@kbn/guided-onboarding-plugin/server/saved_objects/guided_setup';
import { API_BASE_PATH } from '@kbn/guided-onboarding-plugin/common';
import { X_ELASTIC_INTERNAL_ORIGIN_REQUEST } from '@kbn/core-http-common';
import type { FtrProviderContext } from '../../ftr_provider_context';
import { createPluginState, createGuides } from './helpers';
const getDateXDaysAgo = (daysAgo: number): string => {
const date = new Date();
date.setDate(new Date().getDate() - daysAgo);
return date.toISOString();
};
const getStatePath = `${API_BASE_PATH}/state`;
export default function testGetState({ getService }: FtrProviderContext) {
const supertest = getService('supertest');
const kibanaServer = getService('kibanaServer');
describe(`GET ${getStatePath}`, () => {
afterEach(async () => {
// Clean up saved objects
await kibanaServer.savedObjects.clean({
types: [guideStateSavedObjectsType, pluginStateSavedObjectsType],
});
});
it('returns the default plugin state if no saved objects', async () => {
const response = await supertest
.get(getStatePath)
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
.expect(200);
expect(response.body.pluginState).not.to.be.empty();
expect(response.body).to.eql({
pluginState: mockPluginStateNotStarted,
});
});
it('returns the plugin state with an active guide', async () => {
// Create an active guide
await createGuides(kibanaServer, [testGuideStep1ActiveState]);
// Create a plugin state
await createPluginState(kibanaServer, {
status: 'in_progress',
creationDate: new Date().toISOString(),
});
const response = await supertest
.get(getStatePath)
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
.expect(200);
expect(response.body.pluginState).not.to.be.empty();
expect(response.body).to.eql({
pluginState: {
status: 'in_progress',
isActivePeriod: true,
activeGuide: testGuideStep1ActiveState,
},
});
});
it('returns only the plugin state when no guide is active', async () => {
// Create an active guide
await createGuides(kibanaServer, [testGuideNotActiveState]);
// Create a plugin state
await createPluginState(kibanaServer, {
status: 'in_progress',
creationDate: new Date().toISOString(),
});
const response = await supertest
.get(getStatePath)
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
.expect(200);
expect(response.body.pluginState).not.to.be.empty();
expect(response.body).to.eql({
pluginState: {
status: 'in_progress',
isActivePeriod: true,
},
});
});
it('returns isActivePeriod=false if creationDate is 40 days ago', async () => {
// Create a plugin state
await createPluginState(kibanaServer, {
status: 'not_started',
creationDate: getDateXDaysAgo(40),
});
const response = await supertest
.get(getStatePath)
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
.expect(200);
expect(response.body.pluginState).not.to.be.empty();
expect(response.body.pluginState.isActivePeriod).to.eql(false);
});
it('returns isActivePeriod=true if creationDate is 20 days ago', async () => {
// Create a plugin state
await createPluginState(kibanaServer, {
status: 'not_started',
creationDate: getDateXDaysAgo(20),
});
const response = await supertest
.get(getStatePath)
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
.expect(200);
expect(response.body.pluginState).not.to.be.empty();
expect(response.body.pluginState.isActivePeriod).to.eql(true);
});
it('returns the dynamic params', async () => {
// Create an active guide
await createGuides(kibanaServer, [{ ...testGuideStep1ActiveState, params: testGuideParams }]);
// Create a plugin state
await createPluginState(kibanaServer, {
status: 'in_progress',
creationDate: new Date().toISOString(),
});
const response = await supertest
.get(getStatePath)
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
.expect(200);
expect(response.body.pluginState.activeGuide.params).to.eql(testGuideParams);
});
});
}