mirror of
https://github.com/elastic/kibana.git
synced 2025-06-29 03:24:45 -04:00
3a68f8b3ae
fix https://github.com/elastic/kibana/issues/192052 ## Summary Internal APIs will be [restricted](https://github.com/elastic/kibana/issues/163654) from public access as of 9.0.0. In non-serverless environments, this breaking change will result in a 400 error if an external request is made to an internal Kibana API (route `access` option as `"internal"` or `"public"`). This PR allows API owners of non-xpack plugins to run their `ftr` API integration tests against the restriction and adds examples of how to handle it. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Note to reviewers: The header needed to allow access to internal apis shouldn't change your test output, with or without the restriction enabled. ### How to test the changes work: #### Non x-pack: 1. Set `server.restrictInternalApis: true` in `test/common/config.js` 2. Ensure your tests pass #### x-pack: 1. Set `server.restrictInternalApis: true` in `x-pack/test/api_integration/apis/security/config.ts` 2. Ensure the spaces tests pass --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
90 lines
3.1 KiB
TypeScript
90 lines
3.1 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the "Elastic License
|
|
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
|
|
* Public License v 1"; you may not use this file except in compliance with, at
|
|
* your election, the "Elastic License 2.0", the "GNU Affero General Public
|
|
* License v3.0 only", or the "Server Side Public License, v 1".
|
|
*/
|
|
|
|
import expect from '@kbn/expect';
|
|
import { X_ELASTIC_INTERNAL_ORIGIN_REQUEST } from '@kbn/core-http-common';
|
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
|
|
|
export default function ({ getService }: FtrProviderContext) {
|
|
const supertest = getService('supertest');
|
|
const kibanaServer = getService('kibanaServer');
|
|
|
|
describe('create', () => {
|
|
before(async () => {
|
|
await kibanaServer.importExport.load(
|
|
'test/api_integration/fixtures/kbn_archiver/saved_objects/basic.json'
|
|
);
|
|
});
|
|
|
|
after(async () => {
|
|
await kibanaServer.importExport.unload(
|
|
'test/api_integration/fixtures/kbn_archiver/saved_objects/basic.json'
|
|
);
|
|
});
|
|
|
|
it('should return 200', async () => {
|
|
await supertest
|
|
.post(`/api/saved_objects/visualization`)
|
|
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
|
|
.send({
|
|
attributes: {
|
|
title: 'My favorite vis',
|
|
},
|
|
})
|
|
.expect(200)
|
|
.then((resp) => {
|
|
// loose uuid validation
|
|
expect(resp.body)
|
|
.to.have.property('id')
|
|
.match(/^[0-9a-f-]{36}$/);
|
|
|
|
// loose ISO8601 UTC time with milliseconds validation
|
|
expect(resp.body)
|
|
.to.have.property('updated_at')
|
|
.match(/^[\d-]{10}T[\d:\.]{12}Z$/);
|
|
|
|
expect(resp.body).to.eql({
|
|
id: resp.body.id,
|
|
type: 'visualization',
|
|
migrationVersion: resp.body.migrationVersion,
|
|
coreMigrationVersion: '8.8.0',
|
|
typeMigrationVersion: resp.body.typeMigrationVersion,
|
|
managed: resp.body.managed,
|
|
updated_at: resp.body.updated_at,
|
|
created_at: resp.body.created_at,
|
|
version: resp.body.version,
|
|
attributes: {
|
|
title: 'My favorite vis',
|
|
},
|
|
references: [],
|
|
namespaces: ['default'],
|
|
});
|
|
expect(resp.body.migrationVersion).to.be.ok();
|
|
expect(resp.body.typeMigrationVersion).to.be.ok();
|
|
expect(resp.body.managed).to.not.be.ok();
|
|
});
|
|
});
|
|
|
|
it('result should not be updated to the latest Kibana version if there are no migrations', async () => {
|
|
await supertest
|
|
.post(`/api/saved_objects/visualization`)
|
|
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
|
|
.send({
|
|
attributes: {
|
|
title: 'My favorite vis',
|
|
},
|
|
coreMigrationVersion: '8.8.0',
|
|
})
|
|
.expect(200)
|
|
.then((resp) => {
|
|
expect(resp.body.coreMigrationVersion).to.eql('8.8.0');
|
|
});
|
|
});
|
|
});
|
|
}
|