mirror of
https://github.com/elastic/kibana.git
synced 2025-06-28 11:05:39 -04:00
80c142a5db
## Summary This PR fixes an issue introduced in #208776 where switching from ES|QL mode to classic mode in Discover caused the search request to fail with an `unrecognized parameter: [indexType]` error. This was because the `indexType` was actually being sent as part of the search request `params` when it shouldn't have been. We already had some rollup tests that would have caught it, but a workaround was also added to the rollup search strategy to sidestep the issue, preventing the tests from failing. That workaround has been removed and existing ES|QL tests updated to catch the issue specifically for ES|QL mode. Fixes #212704. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) |
||
|---|---|---|
| .. | ||
| apps | ||
| firefox | ||
| fixtures | ||
| page_objects | ||
| screenshots/baseline | ||
| services | ||
| config.base.js | ||
| config.ccs.ts | ||
| config.edge.js | ||
| ftr_provider_context.ts | ||
| jest.config.js | ||
| README.md | ||
Kibana Functional Testing
See our Functional Testing Guide