mirror of
https://github.com/elastic/kibana.git
synced 2025-06-28 11:05:39 -04:00
d0fde5f8e1
Part of https://github.com/elastic/kibana-team/issues/1016#issuecomment-2454845292 Our plan for React@18 packages upgrade is to let kibana contributors now that we're going to bump React packages couple weeks in advance. In addtion to the final PR with green tests and Kibana deployed, we want to give simple instructions on how to run React@18 locally easilly: This PR allows to quickly toggle between version of React locally without having to do anything beyond an environment variable. `REACT_18=true yarn bootstrap` will alias `react` and `react-dom` to v18 in the build. I check that this works as expected when starting from: - local dev server `yarn start` - local ftr `node scripts/functional_tests_server.js` - local unit tests `REACT_18=true yarn test:jest ...` Please note: - **This PR doesn't implement this switch for dist build, as I don't think we need this for our purposes.** - The plan is that we remove this switch soon after we merge React@18 upgrade to main. In addition to the switch this PR mutes a very noisy warning from React@18 about legacy root `Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17.`. This warning is expected as after we upgrade to React@18 packages (Phase 1) we will be in the process of migrating to the new createRoot API (Phase 2). However, it is very noisy and we want to mute it for now. Co-authored-by: Anton Dosov <anton.dosov@elastic.co> |
||
|---|---|---|
| .. | ||
| src | ||
| BUILD.bazel | ||
| index.js | ||
| kibana.jsonc | ||
| package.json | ||
| README.mdx | ||
| tsconfig.json | ||
| webpack.config.js | ||
--- id: kibDevDocsOpsUiSharedDepsNpm slug: /kibana-dev-docs/ops/ui-shared-deps-npm title: "@kbn/ui-shared-deps-npm" description: A package to share single instances of npm external packages across bundles date: 2022-05-24 tags: ['kibana', 'dev', 'contributor', 'operations', 'ui', 'shared', 'deps', 'npm'] --- This is a package of shared dependencies that must only have a single instance and are from the NPM external to the Kibana repository. To consume them, import the package and merge the `externals` export into your webpack externals config so that all references to the supported modules will be remapped to use the global versions.