github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity
kibana/test/functional
History
Stratoula Kalafateli 784411d45d
[Lens] Inline editing of lens panels on a dashboard or canvas (#166169) 
## Summary

Closes https://github.com/elastic/kibana/issues/166833
Closes https://github.com/elastic/kibana/issues/167063

This PR allows the inline editing of Lens panels in canvas and
dashboards.


![inline_editing](8abb636b-7b5a-4d35-9f91-a1bf2ff963f2)

### Changes

#### Discover
- The basic UI change in Discover flyout is that we add the Cancel
button in the flyout footer (resets to the state before the flyout
changes).
- It also solves (with passing the embeddableOutput observable to the
flyout) the bug that is more prominent in this PR ([first
bullet](https://github.com/elastic/kibana/pull/162389#discussion_r1322645626))


#### Dashboard
- All Lens panels have an Edit visualization panel action
- The Edit Lens action is now hidden
- A flyout opens (in the header there is a link where the users can go
to the editor)
- The by reference panels change to by value as long as the users are
editing. On apply and close, we save to the SO
- All tests have changed to accomodate this navigation change. All the
existing ones test the editor (as they used to do). I have added new
tests for testing the inline experience


#### Known issues
- If a user is currently editing a by reference visualization, doesn't
click Cancel or Apply and navigate away, the panel stays as by value
panel. The users can always go back and reset the changes and we could
not find an easy fix with Devon. We consider it as a nice to have and a
non-blocking behavior.


#### Missing
These 2 features are missing to give the full set of capabilities of the
editor to the flyout. Both are missing from ESQL editing too and are
going to be added on a follow up PR
- Chart switcher
- Suggestions (as icons and not previews)

#### Flaky tests runner 

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3182
(100 times)

#### Panel focus
This PR will look even better when this is merged!
https://github.com/elastic/kibana/pull/165417

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2023-09-27 09:56:45 +02:00
..
apps Pick KBN presentation from #166813 (#167361) 2023-09-26 15:41:36 -07:00
firefox [ftr] split dashboard_elements/config to speedup CI run (#160550) 2023-06-28 17:00:34 +02:00
fixtures [Event annotations] Individual annotation editing from library (#163346) 2023-09-20 10:09:17 +03:00
page_objects [Dashboard] Copy panel refactor (#166991) 2023-09-26 10:44:33 -04:00
screenshots [Dashboard] Unskip failing embed_mode screenshot test (#163424) 2023-08-09 08:24:03 -06:00
services [Lens] Inline editing of lens panels on a dashboard or canvas (#166169) 2023-09-27 09:56:45 +02:00
config.base.js [Saved Objects] Adds config flag to toggle hiddenFromHttpApis SO types conditionally (#151512) 2023-02-22 07:59:50 -07:00
config.ccs.ts Getting started ccs tests (#144656) 2022-11-07 18:30:07 -05:00
config.edge.js [ftr] create config file for each tested plugin with firefox tests (#150873) 2023-02-11 00:51:57 +01:00
ftr_provider_context.ts [ftr] implement FtrService classes and migrate common services (#99546) 2021-05-25 09:25:09 -07:00
jest.config.js Elastic License 2.0 (#90099) 2021-02-03 18:12:39 -08:00
README.md Fix dead links to functional testing docs (#85097) 2020-12-14 17:00:53 +01:00

README.md

Kibana Functional Testing

See our Functional Testing Guide