mirror of
https://github.com/elastic/kibana.git
synced 2025-04-25 18:27:59 -04:00
8d2a43a0ce
Resolves https://github.com/elastic/eui-private/issues/171 Resolves https://github.com/elastic/eui-private/issues/177 ## Summary This PR addresses a prior PR review [comment](https://github.com/elastic/kibana/pull/203840/files#diff-bb850523655bac7adb30995553acabae9705435fa51e5b8bf13c483152db694a) by removing `isServerless` from the logic determining what theme should be used at runtime with a simple YML configuration setting instead. I added a non-public `uiSettings.experimental.defaultTheme` config property that defaults to `borealis` and is set to `amsterdam` in `serverless.yml`. Since the default theme is now (and should be) set to Borealis, I also updated `DEFAULT_THEME_NAME` and `FALLBACK_THEME_NAME` to reflect that. This doesn't have any impact on Serverless; it will keep using Amsterdam. Additionally, while making these changes, I wanted to simultaneously improve types and address earlier PR [comment](https://github.com/elastic/kibana/pull/199748#discussion_r1840402343). Now `SUPPORTED_THEME_NAMES` array is declared as `const` making the `ThemeName` type strict instead of resolving a generic `string` type. Usages were updated to use `ThemeName` instead of `string`, too. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| analytics | ||
| application/core-application-browser-mocks | ||
| apps/core-apps-browser-mocks | ||
| base | ||
| capabilities | ||
| chrome/core-chrome-browser-mocks | ||
| deprecations | ||
| doc-links | ||
| elasticsearch | ||
| environment/core-environment-server-mocks | ||
| execution-context | ||
| fatal-errors/core-fatal-errors-browser-mocks | ||
| feature-flags | ||
| http | ||
| i18n | ||
| injected-metadata/core-injected-metadata-browser-mocks | ||
| integrations/core-integrations-browser-mocks | ||
| lifecycle | ||
| logging | ||
| metrics | ||
| node/core-node-server-mocks | ||
| notifications/core-notifications-browser-mocks | ||
| overlays/core-overlays-browser-mocks | ||
| plugins | ||
| preboot/core-preboot-server-mocks | ||
| rendering | ||
| saved-objects | ||
| status/core-status-server-mocks | ||
| test-helpers | ||
| theme/core-theme-browser-mocks | ||
| ui-settings | ||
| usage-data/core-usage-data-server-mocks | ||