mirror of
https://github.com/elastic/kibana.git
synced 2025-06-29 03:24:45 -04:00
## Summary Pre-req for #182535. We're removing the linked to library and drilldown notifications as part of the panel hover actions redesign which gets rid of the title bar in edit mode. We want to prevent panels from having a title bar when titles are hidden and believe these notifications are no longer necessary. The only notification retained is the panel filter notification. <img width="421" alt="Screenshot 2024-08-20 at 6 34 16 AM" src="https://github.com/user-attachments/assets/9f954a6f-3a70-43c9-a3c3-28f92f1efba8"> <img width="269" alt="Screenshot 2024-08-20 at 6 37 18 AM" src="https://github.com/user-attachments/assets/b6c154d5-0b8c-4c8b-ac72-a190d03f8801"> I also did some cleanup and removed unused page objects from the vis, dashboard, and discover functional tests. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
150 lines
4.9 KiB
TypeScript
150 lines
4.9 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the "Elastic License
|
|
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
|
|
* Public License v 1"; you may not use this file except in compliance with, at
|
|
* your election, the "Elastic License 2.0", the "GNU Affero General Public
|
|
* License v3.0 only", or the "Server Side Public License, v 1".
|
|
*/
|
|
|
|
import { FtrProviderContext } from '../ftr_provider_context';
|
|
|
|
export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|
const { common, dashboard } = getPageObjects(['common', 'dashboard']);
|
|
const a11y = getService('a11y');
|
|
const dashboardAddPanel = getService('dashboardAddPanel');
|
|
const dashboardSettings = getService('dashboardSettings');
|
|
const testSubjects = getService('testSubjects');
|
|
const listingTable = getService('listingTable');
|
|
|
|
describe('Dashboard', () => {
|
|
const dashboardName = 'Dashboard Listing A11y';
|
|
const clonedDashboardName = 'Dashboard Listing A11y (1)';
|
|
|
|
it('navitate to dashboard app', async () => {
|
|
await common.navigateToApp('dashboard');
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('create dashboard button', async () => {
|
|
await dashboard.clickNewDashboard();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('save empty dashboard', async () => {
|
|
await dashboard.saveDashboard(dashboardName);
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Open Edit mode', async () => {
|
|
await dashboard.switchToEditMode();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Open add panel', async () => {
|
|
await dashboardAddPanel.clickOpenAddPanel();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('add a visualization', async () => {
|
|
await testSubjects.setValue('savedObjectFinderSearchInput', '[Flights]');
|
|
await testSubjects.click('savedObjectTitle[Flights]-Departures-Count-Map');
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('add a saved search', async () => {
|
|
await dashboardAddPanel.addSavedSearch('[Flights] Flight Log');
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('save the dashboard', async () => {
|
|
await dashboard.saveDashboard(dashboardName, { saveAsNew: false });
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Open Edit mode again', async () => {
|
|
await dashboard.switchToEditMode();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('open settings flyout', async () => {
|
|
await dashboard.openSettingsFlyout();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Should be able to hide panel titles', async () => {
|
|
await dashboardSettings.toggleShowPanelTitles(false);
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Should be able display panels without margins', async () => {
|
|
await dashboardSettings.toggleUseMarginsBetweenPanels(true);
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('close settings flyout', async () => {
|
|
await dashboardSettings.clickCancelButton();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Open add panel again', async () => {
|
|
await dashboardAddPanel.clickOpenAddPanel();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Add one more saved object to cancel it', async () => {
|
|
await testSubjects.setValue('savedObjectFinderSearchInput', '[Flights]');
|
|
await testSubjects.click(
|
|
'savedObjectTitle[Flights]-Airport-Connections-(Hover-Over-Airport)'
|
|
);
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Close add panel', async () => {
|
|
await dashboardAddPanel.closeAddPanel();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Exit out of edit mode', async () => {
|
|
await dashboard.clickCancelOutOfEditMode(false);
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Discard changes', async () => {
|
|
await common.clickConfirmOnModal();
|
|
await dashboard.getIsInViewMode();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
// https://github.com/elastic/kibana/issues/153597
|
|
it.skip('Test full screen', async () => {
|
|
await dashboard.clickFullScreenMode();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
// https://github.com/elastic/kibana/issues/153597
|
|
it.skip('Exit out of full screen mode', async () => {
|
|
await dashboard.exitFullScreenMode();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Make a clone of the dashboard', async () => {
|
|
await dashboard.duplicateDashboard();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Dashboard listing table', async () => {
|
|
await dashboard.gotoDashboardLandingPage();
|
|
await a11y.testAppSnapshot();
|
|
});
|
|
|
|
it('Delete a11y clone dashboard', async () => {
|
|
await listingTable.searchForItemWithName(clonedDashboardName);
|
|
await listingTable.checkListingSelectAllCheckbox();
|
|
await listingTable.clickDeleteSelected();
|
|
await a11y.testAppSnapshot();
|
|
await common.clickConfirmOnModal();
|
|
await listingTable.isShowingEmptyPromptCreateNewButton();
|
|
});
|
|
});
|
|
}
|