mirror of
https://github.com/elastic/kibana.git
synced 2025-06-29 03:24:45 -04:00
fix https://github.com/elastic/kibana/issues/192052 ## Summary Internal APIs will be [restricted](https://github.com/elastic/kibana/issues/163654) from public access as of 9.0.0. In non-serverless environments, this breaking change will result in a 400 error if an external request is made to an internal Kibana API (route `access` option as `"internal"` or `"public"`). This PR allows API owners of non-xpack plugins to run their `ftr` API integration tests against the restriction and adds examples of how to handle it. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Note to reviewers: The header needed to allow access to internal apis shouldn't change your test output, with or without the restriction enabled. ### How to test the changes work: #### Non x-pack: 1. Set `server.restrictInternalApis: true` in `test/common/config.js` 2. Ensure your tests pass #### x-pack: 1. Set `server.restrictInternalApis: true` in `x-pack/test/api_integration/apis/security/config.ts` 2. Ensure the spaces tests pass --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
116 lines
4.5 KiB
TypeScript
116 lines
4.5 KiB
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the "Elastic License
|
|
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
|
|
* Public License v 1"; you may not use this file except in compliance with, at
|
|
* your election, the "Elastic License 2.0", the "GNU Affero General Public
|
|
* License v3.0 only", or the "Server Side Public License, v 1".
|
|
*/
|
|
|
|
import expect from '@kbn/expect';
|
|
import { ReportManager, METRIC_TYPE, UiCounterMetricType } from '@kbn/analytics';
|
|
import type { UserAgentMetric } from '@kbn/analytics';
|
|
import { X_ELASTIC_INTERNAL_ORIGIN_REQUEST } from '@kbn/core-http-common';
|
|
import { FtrProviderContext } from '../../ftr_provider_context';
|
|
|
|
export default function ({ getService }: FtrProviderContext) {
|
|
const supertest = getService('supertest');
|
|
const esArchiver = getService('esArchiver');
|
|
const es = getService('es');
|
|
|
|
const createStatsMetric = (
|
|
eventName: string,
|
|
type: UiCounterMetricType = METRIC_TYPE.CLICK,
|
|
count = 1
|
|
) => ({
|
|
eventName,
|
|
appName: 'myApp',
|
|
type,
|
|
count,
|
|
});
|
|
|
|
const createUserAgentMetric = (appName: string): UserAgentMetric => ({
|
|
appName,
|
|
type: METRIC_TYPE.USER_AGENT,
|
|
userAgent:
|
|
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.87 Safari/537.36',
|
|
});
|
|
|
|
describe('ui_metric savedObject data', () => {
|
|
before(async () => {
|
|
await esArchiver.emptyKibanaIndex();
|
|
});
|
|
|
|
it('increments the count field in the document defined by the {app}/{action_type} path', async () => {
|
|
const reportManager = new ReportManager();
|
|
const uiStatsMetric = createStatsMetric('myEvent');
|
|
const { report } = reportManager.assignReports([uiStatsMetric]);
|
|
await supertest
|
|
.post('/api/ui_counters/_report')
|
|
.set('kbn-xsrf', 'kibana')
|
|
.set('content-type', 'application/json')
|
|
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
|
|
.send({ report })
|
|
.expect(200);
|
|
|
|
const response = await es.search({ index: '.kibana', q: 'type:ui-metric' });
|
|
const ids = response.hits.hits.map(({ _id }: { _id?: string }) => _id!);
|
|
expect(ids.includes('ui-metric:myApp:myEvent')).to.eql(true);
|
|
});
|
|
|
|
it('supports multiple events', async () => {
|
|
const reportManager = new ReportManager();
|
|
const userAgentMetric = createUserAgentMetric('kibana');
|
|
const uiStatsMetric1 = createStatsMetric('myEvent');
|
|
const hrTime = process.hrtime();
|
|
const nano = hrTime[0] * 1000000000 + hrTime[1];
|
|
const uniqueEventName = `myEvent${nano}`;
|
|
const uiStatsMetric2 = createStatsMetric(uniqueEventName);
|
|
const { report } = reportManager.assignReports([
|
|
userAgentMetric,
|
|
uiStatsMetric1,
|
|
uiStatsMetric2,
|
|
]);
|
|
await supertest
|
|
.post('/api/ui_counters/_report')
|
|
.set('kbn-xsrf', 'kibana')
|
|
.set('content-type', 'application/json')
|
|
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
|
|
.send({ report })
|
|
.expect(200);
|
|
|
|
const response = await es.search({ index: '.kibana', q: 'type:ui-metric' });
|
|
const ids = response.hits.hits.map(({ _id }: { _id?: string }) => _id!);
|
|
expect(ids.includes('ui-metric:myApp:myEvent')).to.eql(true);
|
|
expect(ids.includes(`ui-metric:myApp:${uniqueEventName}`)).to.eql(true);
|
|
expect(ids.includes(`ui-metric:kibana-user_agent:${userAgentMetric.userAgent}`)).to.eql(true);
|
|
});
|
|
|
|
it('aggregates multiple events with same eventID', async () => {
|
|
const reportManager = new ReportManager();
|
|
const hrTime = process.hrtime();
|
|
const nano = hrTime[0] * 1000000000 + hrTime[1];
|
|
const uniqueEventName = `my_event_${nano}`;
|
|
const { report } = reportManager.assignReports([
|
|
createStatsMetric(uniqueEventName, METRIC_TYPE.CLICK, 2),
|
|
createStatsMetric(uniqueEventName, METRIC_TYPE.LOADED),
|
|
]);
|
|
await supertest
|
|
.post('/api/ui_counters/_report')
|
|
.set('kbn-xsrf', 'kibana')
|
|
.set('content-type', 'application/json')
|
|
.set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana')
|
|
.send({ report })
|
|
.expect(200);
|
|
|
|
const {
|
|
hits: { hits },
|
|
} = await es.search<any>({ index: '.kibana', q: 'type:ui-metric' });
|
|
|
|
const countTypeEvent = hits.find(
|
|
(hit: { _id?: string }) => hit._id! === `ui-metric:myApp:${uniqueEventName}`
|
|
);
|
|
expect(countTypeEvent?._source['ui-metric'].count).to.eql(3);
|
|
});
|
|
});
|
|
}
|