mirror of
https://github.com/elastic/kibana.git
synced 2025-06-28 19:13:14 -04:00
05916056cd
PR cleans up presentation interface names for consistentency
* adds `$` suffix to all observables. For example, `dataLoading` =>
`dataLoading$`
* removes `Panel` naming convention from interface names since an api
may not be a panel, an api may be a dashboard. For example,
`PublisesPanelTitle` => `PublishesTitle`
#### Note to Reviewers
Pay special attention to any place where your application creates an
untyped API. In the example below, there is no typescript violation when
the parent returns `dataLoading` instead of `dataLoading$` since the
parent is not typed as `PublishesDataLoading`. Please check for
instances like these.
```
<ReactEmbeddableRenderer
getParentApi={() => {
dataLoading: new BehaviorSubject()
}}
/>
```
---------
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
||
|---|---|---|
| .. | ||
| app_link_test | ||
| core_app_status | ||
| core_dynamic_resolving_a | ||
| core_dynamic_resolving_b | ||
| core_history_block | ||
| core_http | ||
| core_plugin_a | ||
| core_plugin_appleave | ||
| core_plugin_b | ||
| core_plugin_chromeless | ||
| core_plugin_deep_links | ||
| core_plugin_deprecations | ||
| core_plugin_execution_context | ||
| core_plugin_helpmenu | ||
| core_plugin_route_timeouts | ||
| core_plugin_static_assets | ||
| core_provider_plugin | ||
| data_search | ||
| elasticsearch_client_plugin | ||
| eui_provider_dev_warning | ||
| hardening | ||
| index_patterns | ||
| kbn_sample_panel_action | ||
| kbn_top_nav | ||
| kbn_tp_custom_visualizations | ||
| management_test_plugin | ||
| rendering_plugin | ||
| saved_object_export_transforms | ||
| saved_object_import_warnings | ||
| saved_objects_hidden_from_http_apis_type | ||
| saved_objects_hidden_type | ||
| session_notifications | ||
| telemetry | ||
| ui_settings_plugin | ||
| usage_collection | ||