mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
eb40f7d249
Backports PR #10681 * Factor out column manipulation in the doc table This refactoring effort turns the implicit manipulation of the set of columns that was scattered throughout the doc table and the field chooser into explicit function calls. This brings with it the following improvements: * The column manipulation code is not duplicated (DRY) * The controller stays in control (IOC) * If the required functions are not provided by the controller, manipulation of the columns is disabled. Additionally, the `discover_field` now uses a properly isolated scope instead of accessing inherited properties of the scope. * Make filter addition and removal in tests more reliable * Change function name to plural, move up ng-if * Remove inconsistent variable initialization * Fix function name typo * Save the state in the action instead of a $watch |
||
|---|---|---|
| .. | ||
| dev_certs | ||
| fixtures | ||
| functional | ||
| screenshots/baseline | ||
| scripts | ||
| support | ||
| unit/api | ||
| utils | ||
| visual_regression | ||
| intern.js | ||
| intern_api.js | ||
| intern_visual_regression.js | ||
| mocha.opts | ||
| mocha_setup.js | ||
| server_config.js | ||
| shield.js | ||