github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-06-28 09:46:03 -04:00
Code Issues Projects Releases Packages Wiki Activity

Allow metrics update when PQ draining (#13935)

Browse source 
This commit moves the stop of metrics collection after pipelines shutdown to allow metrics update during PQ draining
Fixed: #13832
This commit is contained in:
kaisecheng 2022-05-16 15:36:56 +01:00 • committed by GitHub
parent 90e7c8864e
commit 0af9fb0d5f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 55 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

36
qa/integration/specs/monitoring_api_spec.rb
View file

@ -52,6 +52,42 @@ describe "Test Monitoring API" do
end
end
context "queue draining" do
let(:tcp_port) { random_port }
let(:settings_dir) { Stud::Temporary.directory }
let(:queue_config) {
{
"queue.type" => "persisted",
"queue.drain" => true
}
}
let(:config_yaml) { queue_config.to_yaml }
let(:config_yaml_file) { ::File.join(settings_dir, "logstash.yml") }
let(:logstash_service) { @fixture.get_service("logstash") }
let(:config) { @fixture.config("draining_events", { :port => tcp_port }) }
before(:each) do
if logstash_service.settings.feature_flag == "persistent_queues"
IO.write(config_yaml_file, config_yaml)
logstash_service.spawn_logstash("-e", config, "--path.settings", settings_dir)
else
logstash_service.spawn_logstash("-e", config)
end
logstash_service.wait_for_logstash
wait_for_port(tcp_port, 60)
end
it "can update metrics" do
first = logstash_service.monitoring_api.event_stats
Process.kill("TERM", logstash_service.pid)
try(max_retry) do
second = logstash_service.monitoring_api.event_stats
expect(second["filtered"].to_i > first["filtered"].to_i).to be_truthy
end
Process.kill("KILL", logstash_service.pid)
end
end
context "verify global event counters" do
let(:tcp_port) { random_port }
let(:sample_data) { 'Hello World!' }