github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-04-23 22:27:21 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixup rake:version task

Browse source 
Remove no longer nececessary sync task
Simplify other tasks to reflect this removal
Change update_version_file to keep comments in yaml file after task run

Fixes #8410
This commit is contained in:
Rob Bavey 2017-09-28 17:54:13 -04:00
parent 4c090534c9
commit 2fdb917018
1 changed files with 16 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

83
rakelib/version.rake
View file

@ -5,108 +5,57 @@ VERSION_FILE = "versions.yml"
def get_versions
yaml_versions = YAML.safe_load(IO.read(VERSION_FILE))
{
"logstash" => {
"location" => File.join("logstash-core", "lib", "logstash", "version.rb"),
"yaml_version" => yaml_versions["logstash"],
"current_version" => get_version(File.join("logstash-core", "lib", "logstash", "version.rb")),
},
"logstash-core" => {
"location" => File.join("logstash-core", "lib", "logstash-core", "version.rb"),
"yaml_version" => yaml_versions["logstash-core"],
"current_version" => get_version(File.join("logstash-core", "lib", "logstash-core", "version.rb")),
},
"logstash-core-plugin-api" => {
"location" => File.join("logstash-core-plugin-api", "lib", "logstash-core-plugin-api", "version.rb"),
"yaml_version" => yaml_versions["logstash-core-plugin-api"],
"current_version" => get_version(File.join("logstash-core-plugin-api", "lib", "logstash-core-plugin-api", "version.rb")),
}
"logstash" => yaml_versions["logstash"],
"logstash-core" => yaml_versions["logstash-core"],
"logstash-core-plugin-api" => yaml_versions["logstash-core-plugin-api"],
}
end
# Update the version file, keeping the comments in tact
def update_version_file(hash)
existing_content = YAML.safe_load(File.read(VERSION_FILE))
existing_content.merge!(hash)
IO.write(VERSION_FILE, existing_content.to_yaml)
end
def get_version(file)
text = IO.read(file)
version = text.match(/^[A-Z_]+ = "(.+?)"/)
version[1]
existing_versions = YAML.safe_load(File.read(VERSION_FILE))
versions_as_text = IO.read(VERSION_FILE)
%w(logstash logstash-core logstash-core-plugin-api).each do |field|
versions_as_text.gsub!(/(?<=#{field}: )#{existing_versions[field]}/, "#{hash[field]}")
end
IO.write(VERSION_FILE, versions_as_text)
end
namespace :version do
desc "check if the versions.yml is out of sync with .gemspecs and other references"
task :check do
out_of_sync = get_versions.select do |component, metadata|
metadata["yaml_version"] != metadata["current_version"]
end
if out_of_sync.any?
out_of_sync.each do |component, metadata|
puts "#{component} is out of sync. CURRENT: #{metadata['current_version']} | YAML: #{metadata['yaml_version']}"
end
exit(1)
end
end
desc "push versions found in versions.yml to all component version locations"
task :sync do
versions = get_versions
# update version.rb files
versions.select do |component, metadata|
next if metadata["yaml_version"] == metadata["current_version"]
puts "Updating \"#{component}\" from \"#{metadata['current_version']}\" to \"#{metadata['yaml_version']}\""
text = IO.read(metadata["location"])
IO.write(metadata["location"], text.gsub(metadata["current_version"], metadata["yaml_version"]))
end
# ./logstash-core-plugin-api/logstash-core-plugin-api.gemspec: gem.add_runtime_dependency "logstash-core", "5.0.0.dev"
logstash_core_plugin_api_gemspec = File.join("logstash-core-plugin-api", "logstash-core-plugin-api.gemspec")
logstash_core_version = versions['logstash-core']['yaml_version']
text = IO.read(logstash_core_plugin_api_gemspec)
IO.write(logstash_core_plugin_api_gemspec, text.sub(
/ gem.add_runtime_dependency \"logstash-core\", \".+?\"/,
" gem.add_runtime_dependency \"logstash-core\", \"#{logstash_core_version.gsub("-", ".")}\""))
end
desc "show version of core components"
task :show do
Rake::Task["version:sync"].invoke; Rake::Task["version:sync"].reenable
get_versions.each do |component, metadata|
puts "#{component}: #{metadata['yaml_version']}"
get_versions.each do |component, version|
puts "#{component}: #{version}"
end
end
desc "set version of logstash, logstash-core"
task :set, [:version] => [:validate] do |t, args|
hash = {}
get_versions.each do |component, metadata|
get_versions.each do |component, version|
# we just assume that, usually, all components except
# "logstash-core-plugin-api" will be versioned together
# so let's skip this one and have a separate task for it
if component == "logstash-core-plugin-api"
hash[component] = metadata["yaml_version"]
hash[component] = version
else
hash[component] = args[:version]
end
end
update_version_file(hash)
Rake::Task["version:sync"].invoke; Rake::Task["version:sync"].reenable
end
desc "set version of logstash-core-plugin-api"
task :set_plugin_api, [:version] => [:validate] do |t, args|
hash = {}
get_versions.each do |component, metadata|
get_versions.each do |component, version|
if component == "logstash-core-plugin-api"
hash[component] = args[:version]
else
hash[component] = metadata["yaml_version"]
hash[component] = version
end
end
update_version_file(hash)
Rake::Task["version:sync"].invoke; Rake::Task["version:sync"].reenable
end
task :validate, :version do |t, args|