github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-04-24 14:47:19 -04:00
Code Issues Projects Releases Packages Wiki Activity

PERFORMANCE: Remove needless timestamp reference in Event

Browse source 
Fixes #8294
This commit is contained in:
Armin 2017-09-18 10:59:39 +02:00 • committed by Armin Braun
parent 912a84c9fe
commit 6ea7802d50
1 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

19
logstash-core/src/main/java/org/logstash/Event.java
View file

@ -26,7 +26,6 @@ public final class Event implements Cloneable, Queueable {
private boolean cancelled;
private ConvertedMap data;
private ConvertedMap metadata;
private Timestamp timestamp;
public static final String METADATA = "@metadata";
public static final String METADATA_BRACKETS = "[" + METADATA + "]";
@ -48,8 +47,7 @@ public final class Event implements Cloneable, Queueable {
this.data = new ConvertedMap(10);
this.data.putInterned(VERSION, VERSION_ONE);
this.cancelled = false;
this.timestamp = new Timestamp();
this.data.putInterned(TIMESTAMP, this.timestamp);
this.data.putInterned(TIMESTAMP, new Timestamp());
}
/**
@ -84,8 +82,7 @@ public final class Event implements Cloneable, Queueable {
Object providedTimestamp = data.get(TIMESTAMP);
// keep reference to the parsedTimestamp for tagging below
Timestamp parsedTimestamp = initTimestamp(providedTimestamp);
this.timestamp = (parsedTimestamp == null) ? Timestamp.now() : parsedTimestamp;
Accessors.set(data, FieldReference.TIMESTAMP_REFERENCE, timestamp);
data.putInterned(TIMESTAMP, parsedTimestamp == null ? Timestamp.now() : parsedTimestamp);
// the tag() method has to be called after the Accessors initialization
if (parsedTimestamp == null) {
tag(TIMESTAMP_FAILURE_TAG);
@ -114,16 +111,16 @@ public final class Event implements Cloneable, Queueable {
}
public Timestamp getTimestamp() throws IOException {
if (this.data.containsKey(TIMESTAMP)) {
return this.timestamp;
final Timestamp timestamp = (Timestamp) data.get(TIMESTAMP);
if (timestamp != null) {
return timestamp;
} else {
throw new IOException("fails");
}
}
public void setTimestamp(Timestamp t) {
this.timestamp = t;
this.data.putInterned(TIMESTAMP, this.timestamp);
this.data.putInterned(TIMESTAMP, t);
}
public Object getField(final String reference) {
@ -235,9 +232,9 @@ public final class Event implements Cloneable, Queueable {
this.data = e.data;
this.cancelled = e.cancelled;
try {
this.timestamp = e.getTimestamp();
e.getTimestamp();
} catch (IOException exception) {
this.timestamp = new Timestamp();
setTimestamp(new Timestamp());
}
return this;