github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-04-25 07:07:54 -04:00
Code Issues Projects Releases Packages Wiki Activity

Namespace should use a copy of the arrays when creating a sub space

Browse source 
Fix: #5510

Fixes #5513
This commit is contained in:
Pier-Hugues Pellerin 2016-06-16 13:55:23 -04:00 • committed by Jordan Sissel
parent 74672c994b
commit 73c1e68050
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
logstash-core/lib/logstash/instrument/namespaced_metric.rb
View file

@ -45,7 +45,7 @@ module LogStash module Instrument
end end
def namespace(name) def namespace(name)
NamespacedMetric.new(metric, namespace_name.concat(Array(name))) NamespacedMetric.new(metric, namespace_name + Array(name))
end end
private private

7
logstash-core/spec/logstash/instrument/namespaced_metric_spec.rb
View file

@ -22,4 +22,11 @@ describe LogStash::Instrument::NamespacedMetric do
it "returns the value of the block" do it "returns the value of the block" do
expect(subject.time(:duration_ms) { "hello" }).to eq("hello") expect(subject.time(:duration_ms) { "hello" }).to eq("hello")
end end
it "its doesnt change the original `namespace` when creating a subnamespace" do
new_namespace = subject.namespace(:wally)
expect(subject.namespace_name).to eq([namespace])
expect(new_namespace.namespace_name).to eq([:stats, :wally])
end
end end