github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-04-24 06:37:19 -04:00
Code Issues Projects Releases Packages Wiki Activity

add --no-verify to all plugin install commands and prefix also all of them with JAR_SKIP in to improve speed of the acceptance test

Browse source 
exclude jar-dependency when running the plugin manager tests

Fixes #5538
This commit is contained in:
Pere Urbon-Bayes 2016-06-21 14:58:52 +02:00
parent 137c0f1fd5
commit 8bf0afbd4e
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
qa/acceptance/spec/shared_examples/cli/logstash-plugin/install.rb
View file

@ -33,13 +33,13 @@ shared_examples "logstash install" do |logstash|
context "when fetching a gem from rubygems" do
it "successfully install the plugin" do
command = logstash.run_command_in_path("bin/logstash-plugin install logstash-filter-qatest")
command = logstash.run_command_in_path("bin/logstash-plugin install --no-verify logstash-filter-qatest")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-filter-qatest")
end
it "allow to install a specific version" do
command = logstash.run_command_in_path("bin/logstash-plugin install --version 0.1.0 logstash-filter-qatest")
command = logstash.run_command_in_path("bin/logstash-plugin install --no-verify --version 0.1.0 logstash-filter-qatest")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-filter-qatest", "0.1.0")
end

6
qa/acceptance/spec/shared_examples/cli/logstash-plugin/update.rb
View file

@ -16,7 +16,7 @@ shared_examples "logstash update" do |logstash|
let(:previous_version) { "0.1.0" }
before do
logstash.run_command_in_path("bin/logstash-plugin install --version #{previous_version} #{plugin_name}")
logstash.run_command_in_path("bin/logstash-plugin install --no-verify --version #{previous_version} #{plugin_name}")
# Logstash wont update when we have a pinned versionin the gemfile so we remove them
logstash.replace_in_gemfile(',\s"0.1.0"', "")
expect(logstash).to have_installed?(plugin_name, previous_version)
@ -24,7 +24,7 @@ shared_examples "logstash update" do |logstash|
context "update a specific plugin" do
it "has executed succesfully" do
cmd = logstash.run_command_in_path("bin/logstash-plugin update #{plugin_name}")
cmd = logstash.run_command_in_path("bin/logstash-plugin update --no-verify #{plugin_name}")
expect(cmd.stdout).to match(/Updating #{plugin_name}/)
expect(logstash).not_to have_installed?(plugin_name, previous_version)
end
@ -32,7 +32,7 @@ shared_examples "logstash update" do |logstash|
context "update all the plugins" do
it "has executed succesfully" do
logstash.run_command_in_path("bin/logstash-plugin update")
logstash.run_command_in_path("bin/logstash-plugin update --no-verify")
expect(logstash).to have_installed?(plugin_name, "0.1.1")
end
end

2
qa/rspec/commands/base.rb
View file

@ -29,7 +29,7 @@ module ServiceTester
response = nil
at(hosts, {in: :serial}) do |_host|
response = sudo_exec!(cmd)
response = sudo_exec!("JARS_SKIP='true' #{cmd}")
end
response
end