github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-04-24 06:37:19 -04:00
Code Issues Projects Releases Packages Wiki Activity

- only give notice about plugin status once per plugin

Browse source 
Verified by running the test suite and not having a sea of
  "experimental plugin" warnings for the same thing repeatedly.
This commit is contained in:
Jordan Sissel 2013-04-23 23:46:58 -07:00
parent 6061117565
commit cbbd553b1b
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/logstash/config/mixin.rb
View file

@ -159,6 +159,7 @@ module LogStash::Config::Mixin
end
end
subclass.instance_variable_set("@config", subconfig)
@@status_notice_given = false
end # def inherited
def validate(params)
@ -180,11 +181,11 @@ module LogStash::Config::Mixin
docmsg = "For more information about plugin statuses, see http://logstash.net/docs/#{LOGSTASH_VERSION}/plugin-status "
case @plugin_status
when "unsupported"
@logger.warn("Using unsupported plugin '#{@config_name}'. This plugin isn't well supported by the community and likely has no maintainer. #{docmsg}")
@@status_notice_given || @logger.warn("Using unsupported plugin '#{@config_name}'. This plugin isn't well supported by the community and likely has no maintainer. #{docmsg}")
when "experimental"
@logger.warn("Using experimental plugin '#{@config_name}'. This plugin is untested and may change in the future. #{docmsg}")
@@status_notice_given || @logger.warn("Using experimental plugin '#{@config_name}'. This plugin is untested and may change in the future. #{docmsg}")
when "beta"
@logger.info("Using beta plugin '#{@config_name}'. #{docmsg}")
@@status_notice_given || @logger.info("Using beta plugin '#{@config_name}'. #{docmsg}")
when "stable"
# This is cool. Nothing worth logging.
when nil
@ -192,6 +193,7 @@ module LogStash::Config::Mixin
else
raise "#{@config_name} set an invalid plugin status #{@plugin_status}. Valid values are unsupported, experimental, beta and stable. #{docmsg}"
end
@@status_notice_given = true
return true
end