github-mirrors/logstash
1
0
Fork 0
mirror of https://github.com/elastic/logstash.git synced 2025-04-24 06:37:19 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix monitoring api integration race condition

Browse source 
because the metric subsystem may not be ready yet when the tests ask for
the values, the test code may generate a NoMethodError accessing nested
hashes.

The NoMethodError exception aborts the try mechanism instead of retrying.

This PR rescues potential exceptions and adds more expectations to
protect the try block.
This commit is contained in:
Joao Duarte 2017-05-11 13:29:18 +01:00
parent a23b39afa7
commit ede2ca91fc
1 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
qa/integration/specs/monitoring_api_spec.rb
View file

@ -32,8 +32,9 @@ describe "Test Monitoring API" do
end
Stud.try(max_retry.times, RSpec::Expectations::ExpectationNotMetError) do
result = logstash_service.monitoring_api.event_stats
expect(result["in"]).to eq(number_of_events)
# event_stats can fail if the stats subsystem isn't ready
result = logstash_service.monitoring_api.event_stats rescue {}
expect(result["in"]).to eq(number_of_events)
end
end
@ -43,8 +44,11 @@ describe "Test Monitoring API" do
logstash_service.wait_for_logstash
Stud.try(max_retry.times, RSpec::Expectations::ExpectationNotMetError) do
result = logstash_service.monitoring_api.node_stats
expect(result["jvm"]["uptime_in_millis"]).to be > 100
# node_stats can fail if the stats subsystem isn't ready
result = logstash_service.monitoring_api.node_stats rescue nil
expect(result).not_to be_nil
expect(result["jvm"]).not_to be_nil
expect(result["jvm"]["uptime_in_millis"]).to be > 100
end
end
@ -54,7 +58,10 @@ describe "Test Monitoring API" do
logstash_service.wait_for_logstash
Stud.try(max_retry.times, RSpec::Expectations::ExpectationNotMetError) do
result = logstash_service.monitoring_api.node_stats
# node_stats can fail if the stats subsystem isn't ready
result = logstash_service.monitoring_api.node_stats rescue nil
expect(result).not_to be_nil
expect(result["pipeline"]).not_to be_nil
expect(result["pipeline"]["queue"]).not_to be_nil
if logstash_service.settings.feature_flag == "persistent_queues"
expect(result["pipeline"]["queue"]["type"]).to eq "persisted"