Style cleanup

This commit is contained in:
Jordan Sissel 2012-10-16 12:04:24 -07:00
parent a50533d432
commit f7eb8250a3

View file

@ -6,7 +6,7 @@ describe LogStash::Event do
@event = LogStash::Event.new
@event.type = "sprintf"
@event.message = "hello world"
@event.tags = ["tag1"]
@event.tags = [ "tag1" ]
@event.source = "/home/foo"
end
@ -19,55 +19,55 @@ describe LogStash::Event do
end
it "should concatenate tags" do
subject.append(LogStash::Event.new("@tags" => ["tag2"]))
insist { subject.tags } == ["tag1", "tag2"]
subject.append(LogStash::Event.new("@tags" => [ "tag2" ]))
insist { subject.tags } == [ "tag1", "tag2" ]
end
context "when event field is nil" do
it "should add single value as string" do
subject.append(LogStash::Event.new("@fields" => {"field1" => "append1"}))
insist { subject["field1"] } == "append1"
insist { subject[ "field1" ] } == "append1"
end
it "should add multi values as array" do
subject.append(LogStash::Event.new("@fields" => {"field1" => ["append1","append2"]}))
insist { subject["field1"] } == ["append1","append2"]
subject.append(LogStash::Event.new("@fields" => {"field1" => [ "append1","append2" ]}))
insist { subject[ "field1" ] } == [ "append1","append2" ]
end
end
context "when event field is a string" do
before { subject["field1"] = "original1" }
before { subject[ "field1" ] = "original1" }
it "should append string to values, if different from current" do
subject.append(LogStash::Event.new("@fields" => {"field1" => "append1"}))
insist { subject["field1"] } == [ "original1", "append1"]
insist { subject[ "field1" ] } == [ "original1", "append1" ]
end
it "should not change value, if appended value is equal current" do
subject.append(LogStash::Event.new("@fields" => {"field1" => "original1"}))
insist { subject["field1"] } == [ "original1" ]
insist { subject[ "field1" ] } == [ "original1" ]
end
it "should concatenate values in an array" do
subject.append(LogStash::Event.new("@fields" => {"field1" => ["append1"]}))
insist { subject["field1"] } == ["original1", "append1"]
subject.append(LogStash::Event.new("@fields" => {"field1" => [ "append1" ]}))
insist { subject[ "field1" ] } == [ "original1", "append1" ]
end
it "should join array, removing duplicates" do
subject.append(LogStash::Event.new("@fields" => {"field1" => ["append1","original1"]}))
insist { subject["field1"] } == ["original1", "append1"]
subject.append(LogStash::Event.new("@fields" => {"field1" => [ "append1","original1" ]}))
insist { subject[ "field1" ] } == [ "original1", "append1" ]
end
end
context "when event field is an array" do
before { subject["field1"] = ["original1", "original2"] }
before { subject[ "field1" ] = [ "original1", "original2" ] }
it "should append string values to array, if not present in array" do
subject.append(LogStash::Event.new("@fields" => {"field1" => "append1"}))
insist { subject["field1"] } == ["original1", "original2", "append1"]
insist { subject[ "field1" ] } == [ "original1", "original2", "append1" ]
end
it "should not append string values, if the array already contains it" do
subject.append(LogStash::Event.new("@fields" => {"field1" => "original1"}))
insist { subject["field1"] } == ["original1", "original2"]
insist { subject[ "field1" ] } == [ "original1", "original2" ]
end
it "should join array, removing duplicates" do
subject.append(LogStash::Event.new("@fields" => {"field1" => ["append1","original1"]}))
insist { subject["field1"] } == ["original1", "original2", "append1"]
subject.append(LogStash::Event.new("@fields" => {"field1" => [ "append1","original1" ]}))
insist { subject[ "field1" ] } == [ "original1", "original2", "append1" ]
end
end
end