Commit graph

5 commits

Author SHA1 Message Date
Rob Bavey
5d7fa78e09
Fix Windows scripts (#14515)
The work done in #14355 to fix the keystore and plugin scripts erroneously included
%JAVA_OPTS% in the command to invoke `jruby`, rather than as an environment variable, which
prevented these scripts from operating correctly, due to `jruby.exe` not handling Java options,
causing the scripts to crash on invocation.

This commit removes the %JAVA_OPTS% - this is already set as an environment variable, and allows the
scripts to operate correctly
2022-09-09 09:06:57 -04:00
Rob Bavey
59c5374849
Fix windows scripts to also pull settings from JvmOptionsParser (#14355)
* Fix windows scripts to also pull settings from JvmOptionsParser

Prior to this commit, the windows version of the keystore and plugin scripts
diverged from the bash version of these scripts, as they did not pick up Jvm Options
from the JvmOptionsParser, leading to certain mandatory settings not being picked up,
breaking compatibility with Windows on certain versions of the JDK. This PR ensures
that these scripts also use the JvmOptionsParser.

This does not resolve the issue described in #14176, which will be looked at in a future
PR

Relates: #14354

* Add goto :eof as per code review suggestion
2022-07-18 09:03:40 -04:00
Colin Surprenant
6e5b2b2cff bubble up failed exit status 2017-10-12 11:21:13 -04:00
Colin Surprenant
83f6c9fa04 update plugin manager script for setup.bat changes 2017-09-15 17:57:46 -04:00
Suyog Rao
4b07413cd9 Changes after review from @purbon
Fixes #4874
2016-03-24 00:23:15 +00:00
Renamed from bin/plugin.bat (Browse further)