logstash/qa/acceptance/spec/shared_examples/cli/logstash-plugin/install.rb
Cas Donoghue 0e99f526c4
Bump jruby 9.4.13.0 (#17696)
* upgrade jruby to 9.4.11.0

* follow up cleanups

* follow up cleanups

* follow up cleanups

* follow up cleanups

* add licenses

* Update rakelib/plugins-metadata.json

* attempt to fix rubygems

* attempt to fix rubygems

* attempt to fix rubygems

* tweaks for jruby 9.4.12.0 and sha256 validation

* attempt at fixing rubygems

* attempt at fixing rubygems

* attempt at fixing rubygems

* attempt at fixing rubygems

* Bump jruby to 9.4.12.1

* Explicitly require 'set' to make `to_set` available

Something appears to have changed in code loading where this require
is no longer in the call chain. Explicitly require it here.

* Fix up dependency mapper

* Update bundler code with latest rubygems release

This commit makes 2 changes:

1. We were sending a `Gem::Platform` instance to Thor parser instead of a
string. Convert to string version of a platform name. With newly added checks in
Thor, we were getting `noMethodError` for `Gem::Platform`.

2.  It looks like there was a patch to get around a bug in bundler that was
reaching out to the network for local gems. This appears to have been fixed
upstream, this removes the patch.

* Restore patch

* Remove patch (TODO, link to full writeup)

* SPIKE: Take up jruby 9.4.13.0

* Patch bundler cache

Still validating this. Essentially ensure we check local gems when calling cache using
the updated rubygems class.

* WIP: test patch for acceptance tests

* Skip when unable to cache

* Cache every gem

* Fix acceptance test

* Force another route through builtin

* Fixup idea (it returns nil, not raise)

* Fix missing version update

* Fix qatest filter plugin

Without including a gemspec with a locally built gem logstash-plugin list
will not show it in the output.

* Use vendored gem instead of reaching out to rubygems

We vendor an udpated test gem for local install. Use that instead of
reaching out to rubygems.

* Document and comment on the patched bundler code

* Fix test

instead of downloading the "broken" one from rubygems (downloading the `.gem` file directly
does show up in plugin-list), using a vendored one polutes the cache. Use a new vendored
gem

---------

Co-authored-by: João Duarte <jsvduarte@gmail.com>
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
2025-06-24 15:24:52 -07:00

101 lines
4.1 KiB
Ruby

# Licensed to Elasticsearch B.V. under one or more contributor
# license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright
# ownership. Elasticsearch B.V. licenses this file to you under
# the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
require_relative "../../../spec_helper"
require "logstash/version"
require "fileutils"
shared_examples "logstash install" do |logstash|
before(:each) do
logstash.install({:version => LOGSTASH_VERSION})
logstash.write_default_pipeline
end
after(:each) do
logstash.uninstall
end
describe "on [#{logstash.human_name}]" do
context "with a direct internet connection" do
context "when the plugin exist" do
context "from a local `.GEM` file" do
let(:gem_path) { File.expand_path("../../../../fixtures/logstash-filter-acceptance_test-0.1.1.gem", __dir__) }
it "successfully install the plugin" do
command = logstash.run_sudo_command_in_path("bin/logstash-plugin install #{gem_path}")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-filter-acceptance_test")
expect(logstash).not_to be_running
with_running_logstash_service(logstash) do
expect(logstash).to be_running
end
end
end
context "when fetching a gem from rubygems" do
it "successfully install the plugin" do
command = logstash.run_sudo_command_in_path("bin/logstash-plugin install logstash-filter-qatest")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-filter-qatest")
expect(logstash).not_to be_running
with_running_logstash_service(logstash) do
expect(logstash).to be_running
end
end
it "successfully install the plugin when verification is disabled" do
command = logstash.run_sudo_command_in_path("bin/logstash-plugin install --no-verify logstash-filter-qatest")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-filter-qatest")
expect(logstash).not_to be_running
with_running_logstash_service(logstash) do
expect(logstash).to be_running
end
end
it "fails when installing a non logstash plugin" do
command = logstash.run_sudo_command_in_path("bin/logstash-plugin install bundler")
expect(command).not_to install_successfully
expect(logstash).not_to be_running
with_running_logstash_service(logstash) do
expect(logstash).to be_running
end
end
it "allow to install a specific version" do
command = logstash.run_sudo_command_in_path("bin/logstash-plugin install --no-verify --version 0.1.0 logstash-filter-qatest")
expect(command).to install_successfully
expect(logstash).to have_installed?("logstash-filter-qatest", "0.1.0")
with_running_logstash_service(logstash) do
expect(logstash).to be_running
end
end
end
end
context "when the plugin doesnt exist" do
it "fails to install and report an error" do
command = logstash.run_sudo_command_in_path("bin/logstash-plugin install --no-verify logstash-output-impossible-plugin")
expect(command.stderr).to match(/Plugin not found, aborting/)
with_running_logstash_service(logstash) do
expect(logstash).to be_running
end
end
end
end
end
end