logstash/bin
mergify[bot] ba84f96278
Fix pqcheck and pqrepair on Windows (#17210) (#17260)
A recent change to pqheck, attempted to address an issue where the
pqcheck would not on Windows mahcines when located in a folder containing
a space, such as "C:\program files\elastic\logstash". While this fixed an
issue with spaces in folders, it introduced a new issue related to Java options,
and the pqcheck was still unable to run on Windows.

This PR attempts to address the issue, by removing the quotes around the Java options,
which caused the option parsing to fail, and instead removes the explicit setting of
the classpath - the use of `set CLASSPATH=` in the `:concat` function is sufficient
to set the classpath, and should also fix the spaces issue

Fixes: #17209
(cherry picked from commit ba5f21576c)

Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
2025-03-07 16:13:56 -05:00
..
benchmark.bat Quotes java executable path in case it contains spaces (#13881) 2022-03-14 18:17:38 +01:00
benchmark.sh Benchmark: added run script 2017-08-02 15:16:16 +00:00
bundle MINOR: Remove duplication and fix docs in bundler shim 2017-11-06 14:52:40 +00:00
cpdump reference correct class path 2017-07-18 16:21:09 -04:00
dependencies-report instructions on how to run tool, remove unused readlink call in script 2018-08-27 21:44:47 +00:00
ingest-convert.bat Quotes java executable path in case it contains spaces (#13881) 2022-03-14 18:17:38 +01:00
ingest-convert.sh #7329 invoker script for convert jar 2017-06-07 07:17:53 +00:00
logstash Refactor: drop redundant (jruby-complete.jar) dependency (#13159) 2022-02-02 06:55:26 +01:00
logstash-keystore Changed: base-line JRUBY_OPTS to default to --dev 2019-12-03 10:51:44 +00:00
logstash-keystore.bat Fix Windows scripts (#14515) 2022-09-09 09:06:57 -04:00
logstash-plugin Changed: base-line JRUBY_OPTS to default to --dev 2019-12-03 10:51:44 +00:00
logstash-plugin.bat Fix Windows scripts (#14515) 2022-09-09 09:06:57 -04:00
logstash.bat Fix windows scripts to also pull settings from JvmOptionsParser (#14355) 2022-07-18 09:03:40 -04:00
logstash.lib.sh Update to JRuby 9.4 (#14861) 2023-06-28 13:05:43 +02:00
pqcheck fix broken classpath when whitespaces are in the path #9832 2018-07-16 16:43:25 -04:00
pqcheck.bat Fix pqcheck and pqrepair on Windows (#17210) (#17260) 2025-03-07 16:13:56 -05:00
pqrepair fix broken classpath when whitespaces are in the path #9832 2018-07-16 16:43:25 -04:00
pqrepair.bat Fix pqcheck and pqrepair on Windows (#17210) (#17260) 2025-03-07 16:13:56 -05:00
rspec Changed: base-line JRUBY_OPTS to default to --dev 2019-12-03 10:51:44 +00:00
rspec.bat correctly handle paths with spaces 2018-01-11 13:28:15 -05:00
ruby Changed: base-line JRUBY_OPTS to default to --dev 2019-12-03 10:51:44 +00:00
setup.bat Retrive JVM_VERSION from Logstash's home directory (#14797) 2023-01-12 13:56:51 +01:00
system-install Bundle JDK (AdoptOpenJDK 11) in Logstash artifacts (x86_64) 2020-09-23 08:18:31 -07:00