Merge pull request #3669 from jrsupplee/trello-import-links

Add Trello attached links to the card description
This commit is contained in:
Lauri Ojansivu 2021-03-25 11:16:32 +02:00 committed by GitHub
commit 04566d3f40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 28 deletions

View file

@ -981,5 +981,6 @@
"due-date": "Due Date",
"title-alphabetically": "Title (Alphabetically)",
"created-at-newest-first": "Created At (Newest First)",
"created-at-oldest-first": "Created At (Oldest First)"
"created-at-oldest-first": "Created At (Oldest First)",
"links-heading": "Links"
}

View file

@ -416,39 +416,62 @@ export class TrelloCreator {
const attachments = this.attachments[card.id];
const trelloCoverId = card.idAttachmentCover;
if (attachments) {
const links = [];
attachments.forEach(att => {
const file = new FS.File();
// Simulating file.attachData on the client generates multiple errors
// - HEAD returns null, which causes exception down the line
// - the template then tries to display the url to the attachment which causes other errors
// so we make it server only, and let UI catch up once it is done, forget about latency comp.
const self = this;
if (Meteor.isServer) {
file.attachData(att.url, function(error) {
file.boardId = boardId;
file.cardId = cardId;
file.userId = self._user(att.idMemberCreator);
// The field source will only be used to prevent adding
// attachments' related activities automatically
file.source = 'import';
if (error) {
throw error;
} else {
const wekanAtt = Attachments.insert(file, () => {
// we do nothing
});
self.attachmentIds[att.id] = wekanAtt._id;
//
if (trelloCoverId === att.id) {
Cards.direct.update(cardId, {
$set: { coverId: wekanAtt._id },
// if the attachment `name` and `url` are the same, then the
// attachment is an attached link
if (att.name === att.url) {
links.push(att.url);
} else {
const file = new FS.File();
// Simulating file.attachData on the client generates multiple errors
// - HEAD returns null, which causes exception down the line
// - the template then tries to display the url to the attachment which causes other errors
// so we make it server only, and let UI catch up once it is done, forget about latency comp.
const self = this;
if (Meteor.isServer) {
file.attachData(att.url, function(error) {
file.boardId = boardId;
file.cardId = cardId;
file.userId = self._user(att.idMemberCreator);
// The field source will only be used to prevent adding
// attachments' related activities automatically
file.source = 'import';
if (error) {
throw error;
} else {
const wekanAtt = Attachments.insert(file, () => {
// we do nothing
});
self.attachmentIds[att.id] = wekanAtt._id;
//
if (trelloCoverId === att.id) {
Cards.direct.update(cardId, {
$set: { coverId: wekanAtt._id },
});
}
}
}
});
});
}
}
// todo XXX set cover - if need be
});
if (links.length) {
let desc = cardToCreate.description.trim();
if (desc) {
desc += '\n\n';
}
desc += `## ${TAPi18n.__('links-heading')}\n`;
links.forEach(link => {
desc += `* ${link}\n`;
});
Cards.direct.update(cardId, {
$set: {
description: desc,
},
});
}
}
result.push(cardId);
});