github-mirrors/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-04-23 05:27:14 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2683 from insertjokehere/fix_error_on_successful_webhook

Browse source 
Treat any 2xx webhook response status code as success
This commit is contained in:
Lauri Ojansivu 2019-09-06 19:22:36 +03:00 • committed by GitHub
commit ea26f70669
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
server/notifications/outgoing.js
View file

@ -124,7 +124,7 @@ Meteor.methods({
const url = integration.url;
const response = postCatchError(url, options);
if (response && response.statusCode && response.statusCode === 200) {
if (response && response.statusCode && response.statusCode >= 200 && response.statusCode < 300) {
if (is2way) {
const cid = params.commentId;
const tooSoon = Lock.has(cid); // if an activity happens to fast, notification shouldn't fire with the same id