github-mirrors/cva6
1
0
Fork 0
mirror of https://github.com/openhwgroup/cva6.git synced 2025-04-22 21:27:10 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Clean up irrelevant FIXME/TODO (#2915)
Some checks are pending
bender-up-to-date / bender-up-to-date (push) Waiting to run
Details
ci / build-riscv-tests (push) Waiting to run
Details
ci / execute-riscv64-tests (push) Blocked by required conditions
Details
ci / execute-riscv32-tests (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Yannick Casamatta 2025-04-11 12:59:41 +02:00 • committed by GitHub
parent 5355c76147
commit cb27242e17
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/cvxif_issue_register_commit_if_driver.sv
View file

@ -53,9 +53,7 @@ module cvxif_issue_register_commit_if_driver #(
register_o.rs_valid = rs_valid_i;
end
/* WARNING */
// Always commit since speculation in execute in not possible : TODO to be verified
// Always commit since speculation in execute in not possible
// Always do commit transaction with issue
// If instruction goes to execute then it is not speculative
assign commit_valid_o = issue_valid_o && issue_ready_i;

2
core/decoder.sv
View file

@ -192,7 +192,7 @@ module decoder
riscv::OpcodeSystem: begin
instruction_o.fu = CSR;
instruction_o.rs1 = instr.itype.rs1;
instruction_o.rs2 = instr.rtype.rs2; //TODO: needs to be checked if better way is available
instruction_o.rs2 = instr.rtype.rs2; //IMPROVEMENT: needs to be checked if better way is available
instruction_o.rd = instr.itype.rd;
unique case (instr.itype.funct3)