github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Take screenshots after assertions

Browse source 
The screenshots are now taken after the corresponding assertions are
made to make sure they actually depict the expected ui state.
This commit is contained in:
Felix Stürmer 2016-10-17 13:14:32 +02:00
parent a5fe202432
commit 956834430a
No known key found for this signature in database
GPG key ID: F938FEB4935329DA
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/functional/apps/discover/_discover.js
View file

@ -43,10 +43,10 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('save query should show toast message and display query name', async function () {
await PageObjects.discover.saveSearch(queryName1);
var toastMessage = await PageObjects.header.getToastMessage();
await PageObjects.common.saveScreenshot('Discover-save-query-toast');
var expectedToastMessage = `Discover: Saved Data Source "${queryName1}"`;
expect(toastMessage).to.be(expectedToastMessage);
await PageObjects.common.saveScreenshot('Discover-save-query-toast');
await PageObjects.header.waitForToastMessageGone();
var actualQueryNameString = await PageObjects.discover.getCurrentQueryName();
@ -57,10 +57,10 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('load query should show query name', async function () {
await PageObjects.discover.loadSavedSearch(queryName1);
await PageObjects.common.saveScreenshot('Discover-load-query');
await PageObjects.common.try(async function() {
expect(await PageObjects.discover.getCurrentQueryName()).to.be(queryName1);
});
await PageObjects.common.saveScreenshot('Discover-load-query');
});
bdd.it('should show the correct hit count', async function () {
@ -227,8 +227,8 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('should show "no results"', async () => {
var isVisible = await PageObjects.discover.hasNoResults();
await PageObjects.common.saveScreenshot('Discover-no-results');
expect(isVisible).to.be(true);
await PageObjects.common.saveScreenshot('Discover-no-results');
});
bdd.it('should suggest a new time range is picked', async () => {