github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Extract expected values into separate variables

Browse source 
to match convention
This commit is contained in:
Felix Stürmer 2016-10-14 10:48:50 +02:00
parent d4f717016f
commit a5fe202432
No known key found for this signature in database
GPG key ID: F938FEB4935329DA
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
test/functional/apps/discover/_discover.js
View file

@ -36,7 +36,8 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('should show correct time range string by timepicker', async function () {
var actualTimeString = await PageObjects.discover.getTimespanText();
expect(actualTimeString).to.be(`${fromTimeString} to ${toTimeString}`);
var expectedTimeString = `${fromTimeString} to ${toTimeString}`;
expect(actualTimeString).to.be(expectedTimeString);
});
bdd.it('save query should show toast message and display query name', async function () {
@ -44,7 +45,8 @@ bdd.describe('discover app', function describeIndexTests() {
var toastMessage = await PageObjects.header.getToastMessage();
await PageObjects.common.saveScreenshot('Discover-save-query-toast');
expect(toastMessage).to.be(`Discover: Saved Data Source "${queryName1}"`);
var expectedToastMessage = `Discover: Saved Data Source "${queryName1}"`;
expect(toastMessage).to.be(expectedToastMessage);
await PageObjects.header.waitForToastMessageGone();
var actualQueryNameString = await PageObjects.discover.getCurrentQueryName();
@ -62,8 +64,9 @@ bdd.describe('discover app', function describeIndexTests() {
});
bdd.it('should show the correct hit count', async function () {
var expectedHitCount = '14,004';
await PageObjects.common.try(async function() {
expect(await PageObjects.discover.getHitCount()).to.be('14,004');
expect(await PageObjects.discover.getHitCount()).to.be(expectedHitCount);
});
});
@ -80,13 +83,15 @@ bdd.describe('discover app', function describeIndexTests() {
bdd.it('should show correct time range string in chart', async function () {
var actualTimeString = await PageObjects.discover.getChartTimespan();
expect(actualTimeString).to.be(`${fromTimeString} - ${toTimeString}`);
var expectedTimeString = `${fromTimeString} - ${toTimeString}`;
expect(actualTimeString).to.be(expectedTimeString);
});
bdd.it('should show correct initial chart interval of 3 hours', async function () {
var actualInterval = await PageObjects.discover.getChartInterval();
expect(actualInterval).to.be('by 3 hours');
var expectedInterval = 'by 3 hours';
expect(actualInterval).to.be(expectedInterval);
});
bdd.it('should show correct data for chart interval Hourly', async function () {