github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

refactor back to policy list link

Browse source
This commit is contained in:
Ashokaditya 2023-07-07 10:37:55 +02:00
parent 0e281f1191
commit 9e3c771eb7
2 changed files with 58 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

55
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/components/back_to_policy_list_button.tsx Normal file
View file

@ -0,0 +1,55 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React, { memo, useMemo } from 'react';
import { i18n } from '@kbn/i18n';
import { useAppUrl } from '../../../../../common/lib/kibana';
import type { BackToExternalAppButtonProps } from '../../../../components/back_to_external_app_button/back_to_external_app_button';
import { BackToExternalAppButton } from '../../../../components/back_to_external_app_button/back_to_external_app_button';
import { getPoliciesPath } from '../../../../common/routing';
import { APP_UI_ID } from '../../../../../../common';
import type { PolicyDetailsRouteState } from '../../../../../../common/endpoint/types';
export const BackToPolicyListButton = memo<{ backLink?: PolicyDetailsRouteState['backLink'] }>(
({ backLink }) => {
const { getAppUrl } = useAppUrl();
const backLinkOptions = useMemo<BackToExternalAppButtonProps>(() => {
if (backLink) {
const { navigateTo, label, href } = backLink;
return {
onBackButtonNavigateTo: navigateTo,
backButtonLabel: label,
backButtonUrl: href,
};
}
// the default back button is to the policy list
const policyListPath = getPoliciesPath();
return {
backButtonLabel: i18n.translate('xpack.securitySolution.endpoint.list.backToPolicyButton', {
defaultMessage: 'Back to policy list',
}),
backButtonUrl: getAppUrl({ path: policyListPath }),
onBackButtonNavigateTo: [
APP_UI_ID,
{
path: policyListPath,
},
],
};
}, [getAppUrl, backLink]);
if (!backLink) {
return null;
}
return <BackToExternalAppButton {...backLinkOptions} data-test-subj="endpointListBackLink" />;
}
);
BackToPolicyListButton.displayName = 'BackToPolicyListButton';

41
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx
View file

@ -49,11 +49,7 @@ import { FormattedDate } from '../../../../common/components/formatted_date';
import { useNavigateToAppEventHandler } from '../../../../common/hooks/endpoint/use_navigate_to_app_event_handler';
import { EndpointPolicyLink } from '../../../components/endpoint_policy_link';
import { SecurityPageName } from '../../../../app/types';
import {
getEndpointDetailsPath,
getEndpointListPath,
getPoliciesPath,
} from '../../../common/routing';
import { getEndpointDetailsPath, getEndpointListPath } from '../../../common/routing';
import { useFormatUrl } from '../../../../common/components/link_to';
import { useAppUrl } from '../../../../common/lib/kibana/hooks';
import type { EndpointAction } from '../store/action';
@ -65,11 +61,10 @@ import { TableRowActions } from './components/table_row_actions';
import { CallOut } from '../../../../common/components/callouts';
import { metadataTransformPrefix } from '../../../../../common/endpoint/constants';
import { APP_UI_ID, WARNING_TRANSFORM_STATES } from '../../../../../common/constants';
import type { BackToExternalAppButtonProps } from '../../../components/back_to_external_app_button/back_to_external_app_button';
import { BackToExternalAppButton } from '../../../components/back_to_external_app_button/back_to_external_app_button';
import { ManagementEmptyStateWrapper } from '../../../components/management_empty_state_wrapper';
import { useUserPrivileges } from '../../../../common/components/user_privileges';
import { useKibana } from '../../../../common/lib/kibana';
import { BackToPolicyListButton } from './components/back_to_policy_list_button';
const MAX_PAGINATED_ITEM = 9999;
const TRANSFORM_URL = '/data/transform';
@ -122,36 +117,6 @@ export const EndpointList = () => {
const { state: routeState = {} } = useLocation<PolicyDetailsRouteState>();
const backLinkOptions = useMemo<BackToExternalAppButtonProps>(() => {
if (routeState?.backLink) {
return {
onBackButtonNavigateTo: routeState.backLink.navigateTo,
backButtonLabel: routeState.backLink.label,
backButtonUrl: routeState.backLink.href,
};
}
// the default back button is to the policy list
const policyListPath = getPoliciesPath();
return {
backButtonLabel: i18n.translate('xpack.securitySolution.endpoint.list.backToPolicyButton', {
defaultMessage: 'Back to policy list',
}),
backButtonUrl: getAppUrl({ path: policyListPath }),
onBackButtonNavigateTo: [
APP_UI_ID,
{
path: policyListPath,
},
],
};
}, [getAppUrl, routeState?.backLink]);
const backToPolicyList = (
<BackToExternalAppButton {...backLinkOptions} data-test-subj="endpointListBackLink" />
);
useEffect(() => {
// if no endpoint policy, skip transform check
if (!shouldCheckTransforms || !policyItems || !policyItems.length) {
@ -694,7 +659,7 @@ export const EndpointList = () => {
defaultMessage="Hosts running Elastic Defend"
/>
}
headerBackComponent={routeState.backLink && backToPolicyList}
headerBackComponent={<BackToPolicyListButton backLink={routeState.backLink} />}
>
{hasSelectedEndpoint && <EndpointDetailsFlyout />}
<>